Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 231404 - sys-apps/coreutils-6.12: RHEL4 SELinux fix does not work
Summary: sys-apps/coreutils-6.12: RHEL4 SELinux fix does not work
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo non-Linux Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-10 12:09 UTC by Stefan Hoelldampf
Modified: 2008-07-10 19:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
coreutils.patch (coreutils.patch,553 bytes, patch)
2008-07-10 12:25 UTC, Stefan Hoelldampf
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Hoelldampf 2008-07-10 12:09:11 UTC
I am only able to successfully emerge sys-apps/coreutils-6.12 if the RHEL4 SELinux fix is applied to src/Makefile.in. src/Makefile.am does not seem to be enough although automake is used within the ebuild.

Using the following patch, both src/Makefile.am and src/Makefile.in will be modified.
Comment 1 Stefan Hoelldampf 2008-07-10 12:25:41 UTC
Created attachment 160045 [details, diff]
coreutils.patch
Comment 2 Fabian Groffen gentoo-dev 2008-07-10 12:31:02 UTC
I moved the sed up before the eautoreconf, which makes more sense.  That should have the same effect.  Not sure how we ended up adding it there, because I recall having someone problems with it, so it had to be fixed.

Anyhow, can you test if moving the sed up before the eautoreconf solves it as well (without patching .in that is)
Comment 3 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-07-10 13:23:42 UTC
(In reply to comment #2)
> I moved the sed up before the eautoreconf, which makes more sense.  That should
> have the same effect.  Not sure how we ended up adding it there, because I
> recall having someone problems with it, so it had to be fixed.

Weird. and yes, I had this problem, and IIRC I was the one to fix it. Worked for me. 

> Anyhow, can you test if moving the sed up before the eautoreconf solves it as
> well (without patching .in that is)
> 

Comment 4 Stefan Hoelldampf 2008-07-10 13:26:19 UTC
Thanks Fabian, coreutils emerged fine with your changes!

Comment 5 Fabian Groffen gentoo-dev 2008-07-10 13:27:15 UTC
Thanks Stefan for testing.  Does this also mean we need a newer bootstrap image with this fix?
Comment 6 Stefan Hoelldampf 2008-07-10 19:11:43 UTC
That's right, it also failed when bootstrapping.
Comment 7 Fabian Groffen gentoo-dev 2008-07-10 19:42:38 UTC
ok, thanks, I'll create a new snapshot.