Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 229985 - iotop depends on kernel features being enabled
Summary: iotop depends on kernel features being enabled
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Donnie Berkholz (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-29 10:05 UTC by Vincent Legoll
Modified: 2008-07-07 07:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fixing the bug by cmmenting the check (iotop-ebuild.patch,351 bytes, patch)
2008-06-29 10:07 UTC, Vincent Legoll
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Legoll 2008-06-29 10:05:09 UTC
iotop requires kernel features (CONFIG_TASK_IO_ACCOUNTING) at *runtime*
the check of that feature being present at build time is painful and unnecessary
a warning would be fine, though.

Reproducible: Always

Steps to Reproduce:
1. ensure your running kernel has not the required option
2. emerge iotop
3.

Actual Results:  
* Messages for package sys-process/iotop-0.2:

 *   CONFIG_TASK_IO_ACCOUNTING:  is not set when it should be.
 * Please check to make sure these options are set correctly.
 * Failure to do so may cause unexpected problems.
 * Once you have satisfied these options, please try merging
 * this package again.


Expected Results:  
A warning is printed about the missing option, and the emerge still installs the software.

I commented the check in the ebuild:
#CONFIG_CHECK="TASK_IO_ACCOUNTING TASKSTATS"
and the application emerged properly.

and running iotop then has exactly the check needed:
# iotop
Could not run iotop as some of the requirements are not met:
- Python >= 2.5 for AF_NETLINK support: Found
- Linux >= 2.6.20 with I/O accounting support: Not found

The ebuild check is absolutely superfluous and getting in the way.
Comment 1 Vincent Legoll 2008-06-29 10:07:54 UTC
Created attachment 158841 [details, diff]
fixing the bug by cmmenting the check

this patch comments the superfluous check and allowed me to emerge iotop even with a kernel that don't have the required option...
Comment 2 Thomas Faucher 2008-06-29 10:13:34 UTC
Maybe you want to do the same for this one?
  *   CONFIG_TASKSTATS:  is not set when it should be.
Comment 3 Thomas Faucher 2008-06-29 10:42:39 UTC
(In reply to comment #2)
> Maybe you want to do the same for this one?
>   *   CONFIG_TASKSTATS:  is not set when it should be.
Hmm, forget about it, you did comment the full check and not only CONFIG_TASK_IO_ACCOUNTING. I should wear my glasses on wakeup and read more carefully. Sorry!

Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2008-07-01 17:41:26 UTC
What value is there in this? Having an unrunnable package installed doesn't have a lot of use to me. Are you going to forget you wanted to install it between now and rebuilding your kernel?
Comment 5 Vincent Legoll 2008-07-02 08:10:54 UTC
What could I add to the original bug report ?

The install-time check is not needed, it adds no value to the already existing runtime one.
Comment 6 Donnie Berkholz (RETIRED) gentoo-dev 2008-07-07 07:38:51 UTC
Other people asked for this too, so I'm just warning now.