Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 228923 - [PATCH] Allow x11-base/xorg-server-1.4.0.90-r3 to compile with ‘-pedantic’ in CFLAGS
Summary: [PATCH] Allow x11-base/xorg-server-1.4.0.90-r3 to compile with ‘-pedantic’ in...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Lowest trivial (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-22 16:51 UTC by Nico R.
Modified: 2009-03-03 15:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico R. 2008-06-22 16:51:49 UTC 
x11-base/xorg-server-1.4.0.90-r3 fails to emerge if CFLAGS contains ‘-pedantic’. Cause for this is an assignment in hw/xfree86/common/xf86Config.c which does not conform to ISO C. Upstream has already fixed the issue in the git repository.

Patch from upstream available from
http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=commitdiff_plain;h=c67b9c5fc33002b13a2360929a37f24169710f64;hp=0706e5e790060fbf046cfaff295b78806b7841c6

The patch can be applied to xorg-server-1.4.0.90-r3. I have just completed a successful emerge of this combination.


Note:
As vapier said in bug 228725 comment 2, Gentoo does not really care about source code correctness. (That’s why I marked this bug P5 trivial.) Feel free to close this bug as WONTFIX if issues like this one should never be patched in Gentoo. I’m filing it so that someone compiling with ‘-pedantic’ can find a solution for the problem that will appear.

The alternative to adding the patch would be to ‘filter-flags -pedantic’ (which I consider an ugly workaround) …

Thanks. :-)
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2008-07-05 01:14:16 UTC 
Is this fixed by 1.4.99.095?
Comment 2 Nico R. 2008-09-20 07:36:23 UTC 
This bug does not appear with x11-base/xorg-server-1.5.0 anymore. This version includes the patch mentioned in comment #0.

I have not tested 1.4.2 or 1.4.99.*.
Comment 3 Rémi Cardona (RETIRED) gentoo-dev 2009-03-03 15:22:25 UTC 
Closing fixed as per comment #2.

Thanks for the follow up.