Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 228697 - Version bump: HSQLDB 1.8.0.10 ebuild
Summary: Version bump: HSQLDB 1.8.0.10 ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-21 09:03 UTC by Chris Ryan
Modified: 2008-07-04 19:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
hsqldb 1.8.0.10-r1 ebuild (hsqldb-1.8.0.10-r1.ebuild,5.36 KB, text/plain)
2008-06-21 09:04 UTC, Chris Ryan
Details
StringComparator.java (StringComparator.java,3.66 KB, text/plain)
2008-06-21 09:05 UTC, Chris Ryan
Details
Missing file from CVS (StringComparator.java,1.94 KB, text/plain)
2008-07-02 23:21 UTC, Chris Ryan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Ryan 2008-06-21 09:03:28 UTC
New ebuild for HSQLDB 1.8.0.10 based off 1.8.0.9-r1 in the tree.

There was a missing source file in the package download which I managed to extract from a file in the 1.8.0.9-r1 version.

Only tested under x86, jdk 1.6
Comment 1 Chris Ryan 2008-06-21 09:04:08 UTC
Created attachment 157871 [details]
hsqldb 1.8.0.10-r1 ebuild
Comment 2 Chris Ryan 2008-06-21 09:05:56 UTC
Created attachment 157873 [details]
StringComparator.java

I extracted this file from Sort.java in the 1.8.0.9 source as it wasn't in the package download.

I copy it from the files dir to the correct location during the src_unpack.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2008-06-29 22:09:41 UTC
(In reply to comment #2)
> Created an attachment (id=157873) [edit]
> StringComparator.java
> 
> I extracted this file from Sort.java in the 1.8.0.9 source as it wasn't in the
> package download.
> 

Perhaps this file should be extracted from hsqldb version control system instead.
Comment 4 Chris Ryan 2008-07-02 12:26:37 UTC
I've had a hunt through the repo for hsqldb, however this file doesn't exist (http://hsqldb.svn.sourceforge.net/viewvc/hsqldb/base/trunk/src/org/hsqldb/lib/).  From what I can see, it's is in the Sort.java only and I can find no revision log showing StringComparator existing or being extracted from Sort.java.  

What's strange is the Sort.java in the distribution is clearly missing the class, and the build expects it to be a top-level class.  It's as if the author failed to commit the file(s) before making the release.

I've tried to use an extracted Sort.java, but the TestSelf.java fails to compile as it's expecting the StringComparator class, not an inner class of Sort.java.

It's probably not been picked up as it's the tests that fail, and perhaps most people installing don't run the tests...

I've submitted a bug on the issue with HSQLDB project: http://sourceforge.net/tracker/index.php?func=detail&aid=2008754&group_id=23316&atid=378131

At this point, I'm unsure what more can be done to progress this ebuild further.
Comment 5 Chris Ryan 2008-07-02 23:21:17 UTC
Created attachment 159375 [details]
Missing file from CVS

The bug I submitted to hsqldb was updated with the details of the file location (CVS, hsqldb-dev: http://hsqldb.cvs.sourceforge.net/hsqldb/hsqldb-dev/src/org/hsqldb/lib/)
Comment 6 Petteri Räty (RETIRED) gentoo-dev 2008-07-04 19:57:20 UTC
(In reply to comment #5)
> Created an attachment (id=159375) [edit]
> Missing file from CVS
> 
> The bug I submitted to hsqldb was updated with the details of the file location
> (CVS, hsqldb-dev:
> http://hsqldb.cvs.sourceforge.net/hsqldb/hsqldb-dev/src/org/hsqldb/lib/)
> 

Yeah I noticed too and committed.