228413 – [PATCH] media-libs/taglib doesn't pass test w/ gcc-4.3.1

Bug 228413 - [PATCH] media-libs/taglib doesn't pass test w/ gcc-4.3.1

Summary: [PATCH] media-libs/taglib doesn't pass test w/ gcc-4.3.1

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo KDE team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	gcc-4.3
	Show dependency tree

Reported:	2008-06-19 19:04 UTC by Olivier Huber
Modified:	2008-06-20 15:09 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch to make the testsuite compile (test.patch,264 bytes, patch) 2008-06-19 19:05 UTC, Olivier Huber	Details \| Diff
patch for the ebuild (taglib.ebuild.patch,367 bytes, patch) 2008-06-19 19:12 UTC, Olivier Huber	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Olivier Huber 2008-06-19 19:04:14 UTC

In test phase :
test_string.cpp: In member function ‘void TestString::testString()’:
test_string.cpp:50: erreur: ‘strcmp’ was not declared in this scope
test_string.cpp:78: erreur: ‘memcmp’ was not declared in this scope

Comment 1 Olivier Huber 2008-06-19 19:05:09 UTC

Created attachment 157665 [details, diff]
patch to make the testsuite compile

Comment 2 Olivier Huber 2008-06-19 19:12:25 UTC

Created attachment 157667 [details, diff]
patch for the ebuild

Comment 3 Peter Alfredsen (RETIRED) gentoo-dev

2008-06-20 15:09:24 UTC

Next time, please tell us which version it is that fails. I discovered another bug with taglib-1.5 not building tests unless dev-util/cppunit is installed, so initially I wasn't able to reproduce your findings.

+  20 Jun 2008; Peter Alfredsen <loki_val@gentoo.org>
+  +files/taglib-1.5-gcc43-tests.patch, taglib-1.5.ebuild:
+  Add fix to get tests for taglib-1.5 to compile with gcc-4.3. Bug 228413.
+  Thanks to Olivier Huber <oli.huber@gmail.com>.