228185 – dev-libs/libcdio-0.80: incorrect Makefile.am

Bug 228185 - dev-libs/libcdio-0.80: incorrect Makefile.am

Summary: dev-libs/libcdio-0.80: incorrect Makefile.am

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Diego Elio Pettenò (RETIRED)

URL:
Whiteboard:
Keywords:

Duplicates (2):	228351 228655 (view as bug list)
Depends on:
Blocks:

Reported:	2008-06-18 22:02 UTC by Rafał Mużyło
Modified:	2008-06-21 10:30 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
trivial patch (cdparanoia-fix.patch,276 bytes, patch) 2008-06-18 22:04 UTC, Rafał Mużyło	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rafał Mużyło 2008-06-18 22:02:25 UTC

Unless there was a change in autoconf behavior,
libcdio has an incorrect configure.ac.
I had a similar problem recently with hal.
AC_ARG_WITH and AC_ARG_ENABLE first argument should be
in the form foo-bar, not foo_bar. This doesn't hurt us (at least non-minimal build), but is still incorrect.

There's also a very hard to notice bug in Makefile.am, one that causes two pkg-config files to not be installed, a missing backslash.

Comment 1 Rafał Mużyło 2008-06-18 22:04:04 UTC

Created attachment 157509 [details, diff]
trivial patch

This trivial patch corrects pkg-config problem.

Comment 2 Rafał Mużyło 2008-06-18 22:05:16 UTC

Oh, and a minor thing:
configure: WARNING: Unrecognized options: --enable-nls

Comment 3 Rafał Mużyło 2008-06-18 22:11:18 UTC

oops, those configure.ac things, are just inconsistencies, not bugs.

Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev

2008-06-19 23:27:24 UTC

*** Bug 228351 has been marked as a duplicate of this bug. ***

Comment 5 Alexis Ballier gentoo-dev

2008-06-21 07:53:53 UTC

*** Bug 228655 has been marked as a duplicate of this bug. ***

Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev

2008-06-21 10:30:46 UTC

Thanks Rafal, I've fixed it with a different patch so that it also takes care of skipping over the C++ bindings.