Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 22799 - nsplugins.eclass error messages may be confusing
Summary: nsplugins.eclass error messages may be confusing
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All All
: High trivial (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-13 23:43 UTC by John Steele Scott
Modified: 2011-10-30 22:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch which would be sufficient to fix this bug (nsplugins-bug-22799.patch,630 bytes, patch)
2003-06-13 23:46 UTC, John Steele Scott
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Steele Scott 2003-06-13 23:43:35 UTC
In the function inst_plugin() in the nsplugins class, the messages which are
output to the user refer to a java plugin. However, this class can be used for
plugins which have nothing to do with java, e.g. mplayer-plugin. The two einfo
lines in this function should be changed.

I will attach a patch to show what I mean. At the same time, I have changed the
reference to "phoenix" to refer to "firebird".

Reproducible: Always
Steps to Reproduce:
1. Install an ebuild which uses the nsplugins class to install a plugin which is
not a java plugin (e.g. net-www/mplayer-plugin).
Actual Results:  
When emerging such a plugin for the first time, the following is displayed:
"Symlinked the java plugin into the mozilla/phoenix/galeon plugin directory."

Expected Results:  
It should have either said (e.g.)
"Symlinked the MPlayer Plugin into the mozilla/firebird/galeon plugin directory."

or just
"Symlinked the plugin into the mozilla/firebird/galeon plugin directory."

It should not have mentioned anything about java.
Comment 1 John Steele Scott 2003-06-13 23:46:38 UTC
Created attachment 13249 [details, diff]
patch which would be sufficient to fix this bug
Comment 2 SpanKY gentoo-dev 2003-06-16 08:35:53 UTC
wow, thats pretty nitpicky ... i like it ;)

http://cvs.gentoo.org/cgi-bin/viewcvs.cgi/gentoo-x86/eclass/nsplugins.eclass.diff?r1=1.12&r2=1.13