Bug 227197 – net-dialup/rp-pppoe-3.8-r2 stabilization request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alin Năstac (RETIRED) 2008-06-15 14:23:41 UTC]

Please mark it stable ASAP.

[Comment 1 Jeroen Roovers (RETIRED) 2008-06-15 23:33:35 UTC]

Please assign it properly. :)

[Comment 2 Jeroen Roovers (RETIRED) 2008-06-16 00:44:59 UTC]

emerge: there are no ebuilds to satisfy "=net-dialup/rp-ppoe-3.8-r2".

[Comment 3 Jeroen Roovers (RETIRED) 2008-06-17 01:15:10 UTC]

Stable for HPPA.

[Comment 4 Christian Faulhammer (RETIRED) 2008-06-19 12:02:23 UTC]

x86 stable

[Comment 5 Markus Rothe (RETIRED) 2008-06-20 05:18:34 UTC]

now compiling on ppc64:

In file included from /usr/include/linux/if_pppol2tp.h:19,
                 from /usr/include/linux/if_pppox.h:26,
                 from plugin.c:55:
/usr/include/linux/in.h:26: error: redeclaration of enumerator 'IPPROTO_IP'
/usr/include/netinet/in.h:34: error: previous definition of 'IPPROTO_IP' was here
/usr/include/linux/in.h:27: error: redeclaration of enumerator 'IPPROTO_ICMP'
/usr/include/netinet/in.h:38: error: previous definition of 'IPPROTO_ICMP' was here
/usr/include/linux/in.h:28: error: redeclaration of enumerator 'IPPROTO_IGMP'
/usr/include/netinet/in.h:40: error: previous definition of 'IPPROTO_IGMP' was here
/usr/include/linux/in.h:29: error: redeclaration of enumerator 'IPPROTO_IPIP'
/usr/include/netinet/in.h:42: error: previous definition of 'IPPROTO_IPIP' was here
/usr/include/linux/in.h:30: error: redeclaration of enumerator 'IPPROTO_TCP'
/usr/include/netinet/in.h:44: error: previous definition of 'IPPROTO_TCP' was here
/usr/include/linux/in.h:31: error: redeclaration of enumerator 'IPPROTO_EGP'
/usr/include/netinet/in.h:46: error: previous definition of 'IPPROTO_EGP' was here
/usr/include/linux/in.h:32: error: redeclaration of enumerator 'IPPROTO_PUP'
/usr/include/netinet/in.h:48: error: previous definition of 'IPPROTO_PUP' was here
/usr/include/linux/in.h:33: error: redeclaration of enumerator 'IPPROTO_UDP'
/usr/include/netinet/in.h:50: error: previous definition of 'IPPROTO_UDP' was here
/usr/include/linux/in.h:34: error: redeclaration of enumerator 'IPPROTO_IDP'
/usr/include/netinet/in.h:52: error: previous definition of 'IPPROTO_IDP' was here
/usr/include/linux/in.h:36: error: redeclaration of enumerator 'IPPROTO_RSVP'
/usr/include/netinet/in.h:62: error: previous definition of 'IPPROTO_RSVP' was here
/usr/include/linux/in.h:37: error: redeclaration of enumerator 'IPPROTO_GRE'
/usr/include/netinet/in.h:64: error: previous definition of 'IPPROTO_GRE' was here
/usr/include/linux/in.h:39: error: redeclaration of enumerator 'IPPROTO_IPV6'
/usr/include/netinet/in.h:56: error: previous definition of 'IPPROTO_IPV6' was here
/usr/include/linux/in.h:41: error: redeclaration of enumerator 'IPPROTO_ESP'
/usr/include/netinet/in.h:66: error: previous definition of 'IPPROTO_ESP' was here
/usr/include/linux/in.h:42: error: redeclaration of enumerator 'IPPROTO_AH'
/usr/include/netinet/in.h:68: error: previous definition of 'IPPROTO_AH' was here
/usr/include/linux/in.h:44: error: redeclaration of enumerator 'IPPROTO_PIM'
/usr/include/netinet/in.h:80: error: previous definition of 'IPPROTO_PIM' was here
/usr/include/linux/in.h:46: error: redeclaration of enumerator 'IPPROTO_COMP'
/usr/include/netinet/in.h:82: error: previous definition of 'IPPROTO_COMP' was here
/usr/include/linux/in.h:47: error: redeclaration of enumerator 'IPPROTO_SCTP'
/usr/include/netinet/in.h:84: error: previous definition of 'IPPROTO_SCTP' was here
/usr/include/linux/in.h:50: error: redeclaration of enumerator 'IPPROTO_RAW'
/usr/include/netinet/in.h:86: error: previous definition of 'IPPROTO_RAW' was here
/usr/include/linux/in.h:52: error: redeclaration of enumerator 'IPPROTO_MAX'
/usr/include/netinet/in.h:89: error: previous definition of 'IPPROTO_MAX' was here
/usr/include/linux/in.h:56: error: redefinition of 'struct in_addr'
/usr/include/linux/in.h:116: error: redefinition of 'struct ip_mreq'
/usr/include/linux/in.h:122: error: redefinition of 'struct ip_mreqn'
/usr/include/linux/in.h:128: error: redefinition of 'struct ip_mreq_source'
/usr/include/linux/in.h:134: error: redefinition of 'struct ip_msfilter'
/usr/include/linux/in.h:147: error: redefinition of 'struct group_req'
/usr/include/linux/in.h:153: error: redefinition of 'struct group_source_req'
/usr/include/linux/in.h:160: error: redefinition of 'struct group_filter'
/usr/include/linux/in.h:173: error: redefinition of 'struct in_pktinfo'
/usr/include/linux/in.h:181: error: redefinition of 'struct sockaddr_in'
make: *** [plugin/plugin.o] Error 1

[Comment 6 Alin Năstac (RETIRED) 2008-06-20 07:37:17 UTC]

That is a glibc/linux-headers issue. Some of the required headers are now present in glibc (at least version 2.6), but if_pppox.h is installed only by linux-headers. 
Anyway, the definitions/declarations must be the same. Is this a reason not to mark it stable? 'Cause if it is, I urge you to do the same test on the stable revision.

[Comment 7 Markus Rothe (RETIRED) 2008-06-21 21:02:01 UTC]

ppc64 stable. error is no regression. rp-pppoe seems to be replaced by pppd anyways... (as in pppoe work with pppd, too).

[Comment 8 Tobias Klausmann (RETIRED) 2008-06-28 11:39:19 UTC]

Stable on alpha.

[Comment 9 Friedrich Oslage (RETIRED) 2008-06-29 13:19:36 UTC]

(In reply to comment #6)
> That is a glibc/linux-headers issue. Some of the required headers are now
> present in glibc (at least version 2.6), but if_pppox.h is installed only by
> linux-headers. 
> Anyway, the definitions/declarations must be the same. Is this a reason not to
> mark it stable? 'Cause if it is, I urge you to do the same test on the stable
> revision.

Yes, this also affects =net-dialup/rp-pppoe-3.8-r1 (for ppc64 and sparc, the other arches don't have =sys-kernel/linux-headers-2.6.24 marked stable yet).

Meaning, with an up-to-date stable ppc64 and sparc system you can't even compile rp-pppoe.

A quick solution would be to add DEPEND="<sys-kernel/linux-headers-2.6.24" to the ebuild. I didn't check what amount of work is required to change the code to make it compile with recent linux-headers, but that would probably be the preferable solution.

[Comment 10 Friedrich Oslage (RETIRED) 2008-06-30 18:51:10 UTC]

Sparc stable, we downgraded linux-headers for now.

[Comment 11 Alin Năstac (RETIRED) 2008-06-30 21:43:52 UTC]

Fixed as suggested in comment #9.

If someone has the patience to find a proper fix for this piece of ... software, please come up with a better rp-pppoe-3.10-linux-headers.patch.

[Comment 12 nixnut (RETIRED) 2008-08-01 18:59:41 UTC]

ppc stable

[Comment 13 Markus Meier 2008-08-22 21:47:00 UTC]

amd64 stable

[Comment 14 Raúl Porcel (RETIRED) 2008-09-27 16:52:14 UTC]

arm/sh stable, closing