Bug 226275 – gnome-base/gconf: builds tests with FEATURES=-test

• Status: RESOLVED TEST-REQUEST
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2008-06-13 11:54:42 UTC]

The package seems to be building tests during "make all" phase even though I don't have FEATURES=test enabled. For details see my blog: http://blog.flameeyes.eu/articles/2008/06/11/please-dont-build-your-examples-by-default .

It would be nice if the tests were disabled by default and only built with FEATURES=test. You can find an example patch usually suitable for upstream on the blog above.

Thanks,
Diego

[Comment 1 Gilles Dartiguelongue (RETIRED) 2008-10-05 11:19:04 UTC]

Actually according to

http://svn.gnome.org/svn/gconf/branches/gnome-2-18/Makefile.am
http://svn.gnome.org/svn/gconf/branches/gnome-2-20/Makefile.am

and now in trunk, I can't see where it could go into the tests folder. I checked out the repository to fix some other autofoo and I had to manually build tests with make -C tests like you said in your blog. Am I missing something ?

And btw, we are not properly running tests in gconf it seems so it'll have to be fixed in our ebuild (see runtests.sh).

[Comment 2 Mart Raudsepp 2008-10-05 23:06:30 UTC]

Having to call make -C tests/ in src_test is NOT clean and acceptable in my eyes.

[Comment 3 Gilles Dartiguelongue (RETIRED) 2008-10-06 07:03:38 UTC]

actually, the only test that gets built is xml-test.c in gconf. The rest is /tests is not builded and can't be run because the test script is in fact missing from release tarballs.

[Comment 4 Gilles Dartiguelongue (RETIRED) 2008-11-30 11:08:26 UTC]

changing severity for easier searching.

[Comment 5 Pacho Ramos 2010-10-12 18:35:11 UTC]

I have been reviewing gconf-2.32.0 build process and I don't see it's building tests/ when not needed, please recheck and, if still valid, try to provide a build.log to review.

Thanks