Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 226209 - dev-libs/glib: builds tests with FEATURES=-test
Summary: dev-libs/glib: builds tests with FEATURES=-test
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: test-n-example-build
  Show dependency tree
 
Reported: 2008-06-13 11:09 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-12-04 20:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch from overlay (glib-2.17.7-notests.patch,3.77 KB, patch)
2008-09-22 21:15 UTC, Mart Raudsepp
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-06-13 11:09:51 UTC
The package seems to be building tests during "make all" phase even though I don't have FEATURES=test enabled. For details see my blog: http://blog.flameeyes.eu/articles/2008/06/11/please-dont-build-your-examples-by-default .

It would be nice if the tests were disabled by default and only built with FEATURES=test. You can find an example patch usually suitable for upstream on the blog above.

Thanks,
Diego
Comment 1 Mart Raudsepp gentoo-dev 2008-09-22 21:15:19 UTC
Created attachment 166144 [details, diff]
Patch from overlay

Patch currently found in gnome overlay that is applied against glib-2.18.1.
Attaching here, as I'm not going to include this when bumping in portage and it might get removed from overlay afterwards. This should be handled upstream if it already isn't (nothing in URL field).
Comment 2 Mart Raudsepp gentoo-dev 2008-09-25 02:18:35 UTC
Apparently the current patch also requires the following block in the ebuild:

src_test() {
	make -C tests
	make -C glib/tests
	make -C gobject/tests
	make -C gio/tests
	make test
	make -C tests test
	make -C glib/tests test
	make -C gobject/tests test
	make -C gio/tests test
}

and is another reason why this isn't going to portage. It's hackish and needs rework for upstream suitability
Comment 3 Pacho Ramos gentoo-dev 2010-12-04 20:08:30 UTC
Fixed in 2.26.1