Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 226187 - [x11 overlay] x11-misc/xinput-9999 won't build due to getting wrong repository
Summary: [x11 overlay] x11-misc/xinput-9999 won't build due to getting wrong repository
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-13 08:39 UTC by Joel Bosveld
Modified: 2008-06-13 16:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,3.05 KB, text/plain)
2008-06-13 12:48 UTC, Joel Bosveld
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Bosveld 2008-06-13 08:39:02 UTC
It attempts to download from git://anongit.freedesktop.org/git/xorg/util/xinput instead of app/xinput

Reproducible: Always

Steps to Reproduce:
1.add x11 overlay
2.emerge xinput
3....

Actual Results:  
It tries to download from git://anongit.freedesktop.org/git/xorg/util/xinput instead of app/xinput

Expected Results:  
I would expect it to download from the correct repository instead...

I would guess that this (see below) is over-riding the MODULE="app" which is specified in xinput-9999.ebuild, with MODULE="util" as it is in x11-misc category.


line 53 of x-modular.eclass:
[[ -z ${MODULE} ]] && MODULE=""
case ${CATEGORY} in
	app-doc)             MODULE="doc"     ;;
	media-fonts)         MODULE="font"    ;;
	x11-apps|x11-wm)     MODULE="app"     ;;
	x11-misc|x11-themes) MODULE="util"    ;;
	x11-drivers)         MODULE="driver"  ;;
	x11-base)            MODULE="xserver" ;;
	x11-proto)           MODULE="proto"   ;;
	x11-libs)            MODULE="lib"     ;;
esac


Should probably become:
if [[ -z ${MODULE} ]] && MODULE=""; then
case ${CATEGORY} in
	app-doc)             MODULE="doc"     ;;
	media-fonts)         MODULE="font"    ;;
	x11-apps|x11-wm)     MODULE="app"     ;;
	x11-misc|x11-themes) MODULE="util"    ;;
	x11-drivers)         MODULE="driver"  ;;
	x11-base)            MODULE="xserver" ;;
	x11-proto)           MODULE="proto"   ;;
	x11-libs)            MODULE="lib"     ;;
esac
fi

From comment above this section:
# The subdirectory to download source from. Possible settings are app,
# doc, data, util, driver, font, lib, proto, xserver. Set above the
# inherit to override the default autoconfigured module.

so the behaviour of xinput-9999 is correct (it sets MODULE="app" then does inherit x-modular), which leads me to believe that this part of the code is what is wrong

Note, I say a major feature is broken because emerge is a fairly major feature of gentoo ;) - also, if I'm right, then it won't only affect this package, but any x packages that uses MODULE="..."
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2008-06-13 10:42:17 UTC
From which repository did you get this ebuild? There's no -9999 build in the portage tree. (Hint: I would probably have known the answer by now if you had included your `emerge --info'... :)
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2008-06-13 11:10:02 UTC
Oh wait:
1.add x11 overlay
Comment 3 Joel Bosveld 2008-06-13 12:48:29 UTC
Created attachment 156617 [details]
emerge --info
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2008-06-13 16:40:49 UTC
Fixed, thanks!