Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 225983 - dev-libs/apr-1.2.1{1,2}: ebuild works only because it's incorrect
Summary: dev-libs/apr-1.2.1{1,2}: ebuild works only because it's incorrect
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Apache Team - Bugzilla Reports
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-11 22:02 UTC by Rafał Mużyło
Modified: 2009-10-24 15:20 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
a working ebuild (apr-1.3.0.ebuild,2.94 KB, text/plain)
2008-06-14 18:43 UTC, Rafał Mużyło
Details
patch to current ebuild (libtool-fix.patch,926 bytes, patch)
2008-06-14 20:16 UTC, Rafał Mużyło
Details | Diff
smaller patch (libtool-fix.patch,844 bytes, patch)
2008-06-14 20:21 UTC, Rafał Mużyło
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2008-06-11 22:02:53 UTC
Well, this is rather hard to describe.
The short of it is:
libtool doesn't get updated, though _libtoolize is run during eautoreconf.
The real problem is that while getting libtool to be updated is as simple as
adding 
rm "${S}"/build/libtool.m4
before eautoreconf, the real problems start there.
First of all, just to get through eautoreconf, -e 's:LT_VERSION:LLT_VERSION:' has to be done on configure.in (a standard libtool 2 problem)
then top_builddir=@apr_builddir@ has to be added to ${S}/Makefile.in
Next, -e '/RM, rm/d' again for configure.in (that's cause libtool wants RM unset
to set it to 'rm -f')
And here I ran out of ideas: for some reason, even though now it reaches the point when make runs, it fails due to libtool not being created. That's strange,
cause log has line 'config.status: executing libtool commands', so libtool should have been created and when I enter ${S} and manually run './config.status' it is created.
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-06-11 22:12:10 UTC
I think I am suffering with this same very issue in Gentoo Prefix. bug 225675 for future reference. Adding myself to CC to see the result!
Comment 2 Rafał Mużyło 2008-06-12 07:58:05 UTC
And it looks like apr 1.3.0 is suffering the same problem.
The most important thing is:
I don't think that buildconf script will work correctly with libtool 2.
I hope I'm wrong, but it doesn't look that way.
Comment 3 Benedikt Böhm (RETIRED) gentoo-dev 2008-06-12 08:55:31 UTC
apr builds fine here with libtool 2.2
Comment 4 Rafał Mużyło 2008-06-12 09:31:40 UTC
It builds fine with libtool 2.2, just because it's not using it.
As I already said, current ebuild for 1.3.0, though runs eautoconf,
does not update libtool (you should have noticed fortran checks in the build.log,
they mean libtool was NOT updated).
Comment 5 Rafał Mużyło 2008-06-14 18:18:19 UTC
OK, now I feel silly.
I haven't read the whole ebuild, so I missed that it removes the created libtool.
Be back shortly with a working ebuild.
Comment 6 Rafał Mużyło 2008-06-14 18:43:37 UTC
Created attachment 156767 [details]
a working ebuild

OK, now that I think about it, it wasn't that broken in the first place,
but just because we were using /usr/bin/libtool.
Anyway, this ebuild does update libtool.m4 and actually works as expected.
Only error is about libtool not created during AC_PROG_LIBTOOL,
but it does not matter, as we won't be using the created libtool,
and in case it did matter simplest fix seems to be removing the whole block with that grep.
Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2008-06-14 19:20:49 UTC
(In reply to comment #6)
> Created an attachment (id=156767) [edit]
> a working ebuild

Please use `diff -u`.
Comment 8 Rafał Mużyło 2008-06-14 20:16:33 UTC
Created attachment 156777 [details, diff]
patch to current ebuild

OK, this is the diff.
The LT_VERSION sed is only for 1.2, cause 1.3 does AC_SUBST on it,
making it redundant.
Comment 9 Rafał Mużyło 2008-06-14 20:21:37 UTC
Created attachment 156779 [details, diff]
smaller patch

actually this should be enough, top_builddir appears only
for that libtool line.
Comment 10 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-10-24 01:32:04 UTC
Are any changes still needed in dev-libs/apr-1.3.9?
Comment 11 Rafał Mużyło 2009-10-24 02:32:31 UTC
(In reply to comment #10)
> Are any changes still needed in dev-libs/apr-1.3.9?
> 
I completely forgot about this bug.
As I said yes and no.
As we're not really doing full eautoreconf, cause
apache hacks of autotools build process prevent
actually updating libtool this package is shipped with,
but that doesn't matter as we're using system libtool anyway.

I'd say a resolution of WONTFIX would be a good compromise.
Comment 12 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-10-24 15:20:03 UTC
(In reply to comment #11)
> I'd say a resolution of WONTFIX would be a good compromise.

OK. I'm closing this bug.