Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 225601 - dev-util/git-1.5.5.3-r1 fails t0004--unwritable.sh test without FEATURES="userpriv"
Summary: dev-util/git-1.5.5.3-r1 fails t0004--unwritable.sh test without FEATURES="use...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Fernando J. Pereda (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-09 15:49 UTC by Raúl Porcel (RETIRED)
Modified: 2008-08-24 10:50 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raúl Porcel (RETIRED) gentoo-dev 2008-06-09 15:49:05 UTC
*   ok 1: setup
* FAIL 2: write-tree should notice unwritable repository
	
	
		(
			chmod a-w .git/objects
			test_must_fail git write-tree
		)
		status=$?
		chmod 775 .git/objects
		(exit $status)
	
	
* FAIL 3: commit should notice unwritable repository
	
	
		(
			chmod a-w .git/objects
			test_must_fail git commit -m second
		)
		status=$?
		chmod 775 .git/objects
		(exit $status)
	
	
* FAIL 4: update-index should notice unwritable repository
	
	
		(
			echo a >file &&
			chmod a-w .git/objects
			test_must_fail git update-index file
		)
		status=$?
		chmod 775 .git/objects
		(exit $status)
	
	
* FAIL 5: add should notice unwritable repository
	
	
		(
			echo b >file &&
			chmod a-w .git/objects
			test_must_fail git add file
		)
		status=$?
		chmod 775 .git/objects
		(exit $status)
	
	
* failed 4 among 5 test(s)
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-06-26 21:38:19 UTC
Where is your emerge --info?
Retest with 1.5.6.1 and reopen with info if persists.
Comment 2 Fernando J. Pereda (RETIRED) gentoo-dev 2008-06-26 23:35:27 UTC
unwritable fails because root can write to places where it doesn't have permission

- ferdy

Comment 3 Fernando J. Pereda (RETIRED) gentoo-dev 2008-06-27 22:40:07 UTC
Ok, I gave Raúl a patch and he said it is fine. I'll send upstream tomorrow and will locally apply it.

- ferdy

Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-08-24 02:11:23 UTC
i heard nothing on this, the testcase is disabled in 1.6.0 now when running as root.
Comment 5 Fernando J. Pereda (RETIRED) gentoo-dev 2008-08-24 10:50:29 UTC
I sent the patch upstream and they won't accept it, their reason is: running tests as root is stupid.

- ferdy