Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 224103 - [PATCH] app-portage/portage-utils-0.1.29 qlop to recognise concurrent merges
Summary: [PATCH] app-portage/portage-utils-0.1.29 qlop to recognise concurrent merges
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Utils Team
URL:
Whiteboard:
Keywords:
: 263113 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-05-29 15:34 UTC by Nico R.
Modified: 2009-03-20 18:53 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
portage-utils-0.1.29-qlop.patch (portage-utils-0.1.29-qlop.patch,855 bytes, patch)
2008-05-29 15:35 UTC, Nico R.
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico R. 2008-05-29 15:34:03 UTC
qlop does not recognize entries from /var/log/emerge.log if two emerges are interleaved.

Patch from Fabian Groffen and me will be attached soon.
Comment 1 Nico R. 2008-05-29 15:35:29 UTC
Created attachment 154707 [details, diff]
portage-utils-0.1.29-qlop.patch

patch to let qlop search for a mathing completed merge line for a started merge to cope with interleaved merges.
Comment 2 solar (RETIRED) gentoo-dev 2008-05-29 18:12:34 UTC
i don't understand what this patch is supposed to accomplish. Can you please give (before and after) examples.

Thanks in advance.
Comment 3 Fabian Groffen gentoo-dev 2008-05-30 08:24:07 UTC
/var/log/emerge.log can contain the following:

>>> emerge (X of Y) cat/package1
...
*** emerge started
>>> emerge (S of T) cat/package2
::: completed emerge (S of T) cat/package2
*** emerge finished
...
::: completed emerge (X of Y) cat/package1

qlop in this case stops when it sees the "*** emerge started" in this case, because it assumes this means an aborted emerge.  However, in reality it is another emerge started in parallel.

What the patch does, is to look in the log for a matching "completed emerge" for the package that the time is checked for.
Comment 4 Fabian Groffen gentoo-dev 2008-07-18 15:42:06 UTC
With the recent addition of --jobs=X to Portage, this patch (or another fix for the same problem) is more actual than ever.
Comment 5 SpanKY gentoo-dev 2009-03-15 10:10:29 UTC
thanks, added patch to cvs

http://sources.gentoo.org/gentoo-projects/portage-utils/qlop.c?r1=1.42&r2=1.43
Comment 6 Tristan Heaven (RETIRED) gentoo-dev 2009-03-20 18:53:37 UTC
*** Bug 263113 has been marked as a duplicate of this bug. ***