Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 223791 - net-misc/youtube-dl - Why install two executables?
Summary: net-misc/youtube-dl - Why install two executables?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Aggelos Orfanakos (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-27 06:03 UTC by Jeroen Roovers (RETIRED)
Modified: 2008-06-12 08:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2008-05-27 06:03:31 UTC
Index: youtube-dl-2008.04.20.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-misc/youtube-dl/youtube-dl-2008.04.20.ebuild,v
retrieving revision 1.2
diff -u -B -r1.2 youtube-dl-2008.04.20.ebuild
--- youtube-dl-2008.04.20.ebuild        27 May 2008 05:46:18 -0000      1.2
+++ youtube-dl-2008.04.20.ebuild        27 May 2008 06:02:27 -0000
@@ -19,6 +19,5 @@
 }

 src_install() {
-       dobin "${DISTDIR}/${P}"
-       dosym "${P}" "/usr/bin/${PN}"
+       newbin "${DISTDIR}/${P}" ${PN}
 }

Please consider committing this improvement.
Comment 1 Aggelos Orfanakos (RETIRED) gentoo-dev 2008-05-27 17:40:47 UTC
We don't actually install two binaries; we install the one that the program ships with and create a symlink to it. I don't see why we should change this?
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2008-05-27 17:50:54 UTC
Skip that. Why do you want to install two executables?
Comment 3 Aggelos Orfanakos (RETIRED) gentoo-dev 2008-05-27 22:23:10 UTC
Why not? I thought it'd be useful to have the executable available as upstream ships it.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2008-05-27 23:00:50 UTC
But then you wouldn't need the symlink. :)
Comment 5 Aggelos Orfanakos (RETIRED) gentoo-dev 2008-05-28 09:57:40 UTC
I'm not sure what you mean. This way, we have the executable as upstream ships it (youtube-dl-YYYY-MM-DD), plus a handly symlink that points to it (youtube-dl).
Comment 6 Aggelos Orfanakos (RETIRED) gentoo-dev 2008-06-12 08:29:52 UTC
I guess you can learn about the version by issuing `youtube-dl -v`. I've incorporated your suggestion in the new version of youtube-dl, released a few days ago, but I don't think changing all previous ebuilds for something as cosmetic as that is worth it. Thanks!