Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 223743 - Ebuild for OpenTyrian (SVN snapshot)
Summary: Ebuild for OpenTyrian (SVN snapshot)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: AMD64 Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL: http://code.google.com/p/opentyrian/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-26 19:29 UTC by Tony Vroon (RETIRED)
Modified: 2008-12-12 14:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
opentyrian-20080526.ebuild (opentyrian-20080526.ebuild,1.00 KB, text/plain)
2008-05-26 19:30 UTC, Tony Vroon (RETIRED)
Details
20080526-datapath.diff (20080526-datapath.diff,413 bytes, patch)
2008-05-26 19:31 UTC, Tony Vroon (RETIRED)
Details | Diff
20080526-scale2x-makefile.diff (20080526-scale2x-makefile.diff,294 bytes, patch)
2008-05-26 19:31 UTC, Tony Vroon (RETIRED)
Details | Diff
opentyrian-20080526.ebuild (opentyrian-20080526.ebuild,1.09 KB, text/plain)
2008-05-26 20:09 UTC, Tony Vroon (RETIRED)
Details
20080526-datapath.diff (20080526-datapath.diff,727 bytes, patch)
2008-05-26 20:09 UTC, Tony Vroon (RETIRED)
Details | Diff
opentyrian svn ebuild (opentyrian-9999.ebuild,1.39 KB, text/plain)
2008-06-13 11:16 UTC, corec
Details
opentyrian datapath patch. just renamed from snapshot version. (9999-datapath.diff,727 bytes, text/plain)
2008-06-13 11:17 UTC, corec
Details
opentyrian-20080628.ebuild (opentyrian-20080628.ebuild,1004 bytes, text/plain)
2008-06-28 20:48 UTC, Tony Vroon (RETIRED)
Details
20080628-datapath.diff (20080628-datapath.diff,727 bytes, patch)
2008-06-28 20:50 UTC, Tony Vroon (RETIRED)
Details | Diff
Updated datapath patch to apply to latest SVN (opentyrian-datapath.diff,712 bytes, patch)
2008-07-30 03:55 UTC, Paul Arthur
Details | Diff
opentyrian-20081109.ebuild (opentyrian-20081109.ebuild,1.10 KB, text/plain)
2008-11-09 23:15 UTC, Tony Vroon (RETIRED)
Details
20081109-datapath.diff (20081109-datapath.diff,869 bytes, patch)
2008-11-09 23:16 UTC, Tony Vroon (RETIRED)
Details | Diff
20081109-makefile.diff (20081109-makefile.diff,1.12 KB, patch)
2008-11-09 23:16 UTC, Tony Vroon (RETIRED)
Details | Diff
opentyrian-20081109.ebuild (opentyrian-20081109.ebuild,1.19 KB, text/plain)
2008-11-09 23:43 UTC, Tony Vroon (RETIRED)
Details
opentyrian-20081109.ebuild (opentyrian-20081109.ebuild,1.17 KB, text/plain)
2008-11-10 00:00 UTC, Tony Vroon (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Vroon (RETIRED) gentoo-dev 2008-05-26 19:29:59 UTC
OpenTyrian is an open-source (GPL2) port of the DOS game Tyrian. The developers have been issued with the original Turbo Pascal source, but they can not redistribute it. Instead, they're rewriting the game in C using SDL.
Will attach ebuild and patches shortly.
Comment 1 Tony Vroon (RETIRED) gentoo-dev 2008-05-26 19:30:42 UTC
Created attachment 154381 [details]
opentyrian-20080526.ebuild
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2008-05-26 19:31:04 UTC
Created attachment 154383 [details, diff]
20080526-datapath.diff
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2008-05-26 19:31:33 UTC
Created attachment 154385 [details, diff]
20080526-scale2x-makefile.diff
Comment 4 Tristan Heaven (RETIRED) gentoo-dev 2008-05-26 19:43:18 UTC
needs to use ${GAMES_DATADIR} for the patch as well. /usr/share/games is just the default
Comment 5 Tony Vroon (RETIRED) gentoo-dev 2008-05-26 19:48:50 UTC
Noted, will update.
Comment 6 Tony Vroon (RETIRED) gentoo-dev 2008-05-26 20:09:04 UTC
Created attachment 154389 [details]
opentyrian-20080526.ebuild

Specify DATA_PATH instead of hardcoding it.
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2008-05-26 20:09:49 UTC
Created attachment 154391 [details, diff]
20080526-datapath.diff

The Makefile passes the DATA_PATH on, use it in the source. </hardcoding>
Comment 8 Tristan Heaven (RETIRED) gentoo-dev 2008-06-11 20:44:20 UTC
Are you waiting for us? It looks okay to me now...
Comment 9 Mr. Bones. (RETIRED) gentoo-dev 2008-06-11 21:14:46 UTC
it really deps on dev-util/subversion?

call epatch once

error check the sed.

make make a desktop entry
Comment 10 Tony Vroon (RETIRED) gentoo-dev 2008-06-11 22:34:46 UTC
(In reply to comment #9)
> it really deps on dev-util/subversion?

Yes, it wants to create a build stamp. I can hardcode it if required, but that does mean the tarballs are not longer fire and forget.

> call epatch once

Ah, supports multiple arguments. Never used it that way. Will do.
 
> error check the sed.

Okay, will add a || die.

> make make a desktop entry

*nod*

Comment 11 corec 2008-06-13 11:15:05 UTC
I made a svn ebuild of opentyrian and decided that if I share it here, somebody else could use it if needed. It's my first ebuild so hopefully it works for you. :) 

I used your datapath patch.
Comment 12 corec 2008-06-13 11:16:10 UTC
Created attachment 156603 [details]
opentyrian svn ebuild
Comment 13 corec 2008-06-13 11:17:02 UTC
Created attachment 156605 [details]
opentyrian datapath patch. just renamed from snapshot version.
Comment 14 Tony Vroon (RETIRED) gentoo-dev 2008-06-28 20:48:33 UTC
Created attachment 158803 [details]
opentyrian-20080628.ebuild
Comment 15 Tony Vroon (RETIRED) gentoo-dev 2008-06-28 20:50:22 UTC
Created attachment 158805 [details, diff]
20080628-datapath.diff
Comment 16 Tony Vroon (RETIRED) gentoo-dev 2008-06-28 20:51:33 UTC
(In reply to comment #9)
> error check the sed.

Done.

> make make a desktop entry

Will do that now. The scale2x patch has been dropped as upstream rewrote the graphics system. Scalers are now selectable at runtime. It seems to have broken the jukebox at this point in time, but actual gameplay is working fine. 

Comment 17 Paul Arthur 2008-07-30 03:55:42 UTC
Created attachment 161685 [details, diff]
Updated datapath patch to apply to latest SVN

Older patches no longer apply to current SVN due to added #ifndef.
Comment 18 Tony Vroon (RETIRED) gentoo-dev 2008-11-09 23:15:40 UTC
Created attachment 171241 [details]
opentyrian-20081109.ebuild

Moved sed statements out to separate patch.
Use provided pixmap & desktop file.
Comment 19 Tony Vroon (RETIRED) gentoo-dev 2008-11-09 23:16:23 UTC
Created attachment 171242 [details, diff]
20081109-datapath.diff
Comment 20 Tony Vroon (RETIRED) gentoo-dev 2008-11-09 23:16:52 UTC
Created attachment 171244 [details, diff]
20081109-makefile.diff

Add some CFLAGS & LDFLAGS respect.
Comment 21 Tony Vroon (RETIRED) gentoo-dev 2008-11-09 23:17:27 UTC
Please consider for inclusion, this addresses all your comments.
Comment 22 Tomáš Chvátal (RETIRED) gentoo-dev 2008-11-09 23:31:43 UTC
update:
	dogamesbin tyrian || die "dogamesbin failed"
	dodoc CREDITS NEWS README
	insinto /usr/share/applications/
	doins opentyrian.desktop
	insinto /usr/share/pixmaps/
	doins tyrian.xpm
	insinto "${GAMES_DATADIR}/${PN}"
	cd "${WORKDIR}/tyrian21"
	doins * || die "doins failed"
	prepgamesdirs
with:
	dogamesbin tyrian || die "dogamesbin failed"
	dodoc CREDITS NEWS README || die "dodoc failed"
	domenu opentyrian.desktop || die "domenu failed"
	doicon tyrian.xpm || die "doicon failed "
	insinto "${GAMES_DATADIR}/${PN}"
	cd "${WORKDIR}/tyrian21"
	doins * || die "doins failed"
	prepgamesdirs


also useq can be replaced by plain use

in epatch only "${FILESDIR}"/someobscure.patch needs quoting

that sed needs || die

btw what for it needs subversion as its dep it updates itself?
Comment 23 Tony Vroon (RETIRED) gentoo-dev 2008-11-09 23:43:18 UTC
Created attachment 171247 [details]
opentyrian-20081109.ebuild

New comments, new ebuild.
Comment 24 Tony Vroon (RETIRED) gentoo-dev 2008-11-09 23:44:58 UTC
(In reply to comment #22)
> also useq can be replaced by plain use

If it's silent these days. Printing the USE-flag name is ugly.
 
> btw what for it needs subversion as its dep it updates itself?

To generate the version stamp. Otherwise the developer needs to generate it as part of the tarball creation process, which makes rolling a tarball unnecessarily complicated.
Comment 25 Tony Vroon (RETIRED) gentoo-dev 2008-11-10 00:00:51 UTC
Created attachment 171248 [details]
opentyrian-20081109.ebuild

As use is indeed silent these days, no need for useq.
Added die to debug sed as requested.
Fed makefile patch upstream where it was accepted, dropped from ebuild.
The ebuild is once again in line with all review comments.
Comment 26 Yuri Schlesner 2008-11-19 01:37:42 UTC
Just dropping by to note that I added support for home directories and custom data paths to the Enhanced branch (revision 826), this should make it easier to make an ebuild for that version now. (If anyone has any changes to suggest I'm all ears, too.)

For installation into the distribution, ideally, the only file which needs to be patched is autorun/00paths.con.
Comment 27 Tony Vroon (RETIRED) gentoo-dev 2008-12-11 15:15:52 UTC
Mr_Bones has approved this on behalf of the games herd. The distfile is now being mirrored out, so I will commit in a few hours. Ebuild is lined up:
+*opentyrian-20081211 (11 Dec 2008)
+
+  11 Dec 2008; <chainsaw@gentoo.org> +files/20081211-datapath.diff,
+  +metadata.xml, +opentyrian-20081211.ebuild:
+  Initial commit, ebuild by me. Closes bug #223743. With thanks to Mr_Bones
+  & nyhm for review comments.

This is upstream "classic", SVN revision 835. It will install as 835M because of the data path patching.
Comment 28 Tony Vroon (RETIRED) gentoo-dev 2008-12-12 14:22:22 UTC
Well, few more hours. Anyhow, this way we can be sure it's all on the mirrors. Thanks to everyone contributing to this bug report, enjoy the game :)