Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 223537 - Gimmix progress bar shows garbage next to time
Summary: Gimmix progress bar shows garbage next to time
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-25 10:04 UTC by Jean-François Wauthy
Modified: 2008-09-28 14:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Ebuild applying bugfix (gimmix-0.4.3-r1.ebuild,1019 bytes, text/plain)
2008-05-25 10:05 UTC, Jean-François Wauthy 		Details
patch fixing the issue (gimmix-0.4.3-timestring-overflow.patch,385 bytes, text/plain)
2008-05-25 10:05 UTC, Jean-François Wauthy 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-François Wauthy 2008-05-25 10:04:18 UTC 
The progress bar shows memory garbage next to the current time position of the played song.

This problem appears when going over the 100th minute of playing indicating an eventual problem of buffer overflow. Looking in the source code I found out that the time string is limited to 15 caracters which is too short for a long track (i.e. 431 minutes).

The solution is simply to allocate a larger string on the stack or to dynamically allocate it on the heap.

The bug has been reported upstream: https://bugs.launchpad.net/gimmix/+bug/234739

Reproducible: Always

Steps to Reproduce:
Comment 1 Jean-François Wauthy 2008-05-25 10:05:20 UTC 
Created attachment 154243 [details]
Ebuild applying bugfix
Comment 2 Jean-François Wauthy 2008-05-25 10:05:43 UTC 
Created attachment 154245 [details]
patch fixing the issue
Comment 3 Christoph Mende (RETIRED) gentoo-dev 2008-09-28 14:34:54 UTC 
This is fixed in gimmix-0.5.0