Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 223531 - net-nds/luma: file collisions updating from 2.3 to 2.4
Summary: net-nds/luma: file collisions updating from 2.3 to 2.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-25 09:39 UTC by Martin von Gagern
Modified: 2008-05-31 11:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
disable indented doCompile (223531.patch,281 bytes, patch)
2008-05-25 10:03 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2008-05-25 09:39:00 UTC
Trying to update from luma-2.3 to luma-2.4, I got 442 file collitions for *.pyc files. It seems that the old version only installed the *.pyc files in pkg_postinst using python_mod_optimize, whereas 2.4 seems to compile them in the install phase as well.

Possible solutions:

1. Accept that's the way things are, but issue a message if old compiled files are installed, so that users know how to proceed.

2. Consider the generation of the *.pyc files an error in the ebuild, as the sed command disabling doCompile is still in place. Try to find its cause and prevent it from happening.

3. Get rid of all that python magic in pkg_postinst, and find a way to get modules compiled properly before merging them, so that file ownership and checksums are properly recorded. If the reason for current setup is that python can compile files only in their final location, maybe an LD_PRELOAD library could be used to simulate something like an union fs, so that source files are opened in the image directory as if they were in the final location, and compiled files are placed in the image directory as well. Would probably affect quite a lot of python packages. Is there a bug report for this yet?
Comment 1 Martin von Gagern 2008-05-25 10:03:45 UTC
Created attachment 154241 [details, diff]
disable indented doCompile

(In reply to comment #0)
> I got 442 file collitions for *.pyc files.

Sorry, 442 is the complete number of files to be merged; the number of file collisions is not given, but definitely lower. There are 128 *.pyc files in the image directory.

> 2. Consider the generation of the *.pyc files an error in the ebuild, as the
> sed command disabling doCompile is still in place. Try to find its cause and
> prevent it from happening.

The attached patch to the ebuild disables indented calls of doCompile as well as unendented ones. This catches the instance in doCkecks as well. The call to doChecks has been added in 2.4, so there lies the cause for the difference.
Comment 2 Ali Polatel (RETIRED) gentoo-dev 2008-05-31 11:32:14 UTC
Fixed in CVS. Thanks for reporting :-)