Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 223349 - app-text/odin-0.1.4: new package
Summary: app-text/odin-0.1.4: new package
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: Low enhancement
Assignee: Default Assignee for New Packages
URL: http://odin.sourceforge.net
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2008-05-23 14:14 UTC by Ivan Anishchuk
Modified: 2017-08-25 17:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild (odin-0.1.2.ebuild,496 bytes, text/plain)
2008-05-23 14:16 UTC, Ivan Anishchuk
Details
ebuild for odin-0.1.3 (odin-0.1.3.ebuild,907 bytes, text/plain)
2009-07-16 05:42 UTC, Ivan Anishchuk
Details
ebuild for odin-0.1.3 (odin-0.1.3.ebuild,907 bytes, text/plain)
2009-07-16 05:42 UTC, Ivan Anishchuk
Details
ebuild for odin-0.1.3 (odin-0.1.3.ebuild,656 bytes, text/plain)
2009-07-23 14:38 UTC, Ivan Anishchuk
Details
ebuild for odin-0.1.3 (odin-0.1.3.ebuild,634 bytes, text/plain)
2009-07-24 11:17 UTC, Ivan Anishchuk
Details
patch to fix problem with zip-archives (odin-0.1.3-zipfix.patch,528 bytes, patch)
2009-07-24 11:20 UTC, Ivan Anishchuk
Details | Diff
ebuild for odin-0.1.4 (odin-0.1.4.ebuild,562 bytes, text/plain)
2009-10-20 19:30 UTC, Ivan Anishchuk
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Anishchuk 2008-05-23 14:14:53 UTC
E-book reader for GTK & GNOME. Based on PyBookReader. It can read FictionBook (fb2) files.

Reproducible: Always
Comment 1 Ivan Anishchuk 2008-05-23 14:16:04 UTC
Created attachment 154067 [details]
Ebuild
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-05-24 14:49:02 UTC
have you actually tested this packages on all arches in KEYWORD ?
and also invert the RDEPEND/DEPEND assignation.
Comment 3 Ivan Anishchuk 2008-05-26 14:33:32 UTC
(In reply to comment #2)
> have you actually tested this packages on all arches in KEYWORD ?
No, it's only tested on alpha, amd64, ia64, x86, but i can't see any problem to run it on any other arch. This is my first ebuild, i must remove keyword if package is not tested on this arch? ok
> and also invert the RDEPEND/DEPEND assignation.
Theese are both compile-time deps.

Comment 4 Ivan Anishchuk 2008-05-26 14:35:13 UTC
Comment on attachment 154067 [details]
Ebuild

# Copyright 1999-2005 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $

inherit distutils

DESCRIPTION="PyGTK-based book reader for plain text and fb2 books"
HOMEPAGE="http://odin.sourceforge.net/"
SLOT="0"
LICENSE="GPL-2"
KEYWORDS="~alpha ~amd64 ~ia64 ~x86"
SRC_URI="mirror://sourceforge/odin/${P}.tar.bz2"

DEPEND="virtual/python
		 >=dev-python/pygtk-2.2
		 dev-libs/libxml2"
RDEPEND="${DEPEND}"
Comment 5 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-11-30 11:15:28 UTC
align ebuild requests to same values
Comment 6 Ivan Anishchuk 2009-07-16 05:42:23 UTC
Created attachment 198124 [details]
ebuild for odin-0.1.3

Oh... I forget about it :( . This was presumably the last version.
Package is close to be abandoned. If anybody is interested in it, pick them up :) . Now I'm planning to make something about, but from scratch.
Comment 7 Ivan Anishchuk 2009-07-16 05:42:25 UTC
Created attachment 198125 [details]
ebuild for odin-0.1.3

Oh... I forget about it :( . This was presumably the last version.
Package is close to be abandoned. If anybody is interested in it, pick them up :) . Now I'm planning to make something about, but from scratch.
Comment 8 Ivan Anishchuk 2009-07-16 05:43:34 UTC
sorry about dubs
Comment 9 Romain Perier (RETIRED) gentoo-dev 2009-07-19 19:00:30 UTC
Like you said apparently package seems to be abandoned, the last commit was send 14 months ago, and the last release is 1 year old.
It could be annoying in case of problem if we need to get feedbacks from upstream devs, and so on.
However it's just my opinion :)
Comment 10 Ivan Anishchuk 2009-07-23 05:25:36 UTC
I'm upstream developer :) I will fix small bugs and accept patches, but i'm going to make another similar program from scratch and haven't enough time to support this...
Comment 11 Romain Perier (RETIRED) gentoo-dev 2009-07-23 06:10:26 UTC
(In reply to comment #10)
> I'm upstream developer :) I will fix small bugs and accept patches, but i'm
> going to make another similar program from scratch and haven't enough time to
> support this...
> 

Okay so if you're an upstream developer don't consider what I said ;)

Just few things:

- As Gilles asked you, please fix RDEPEND and DEPEND
- In src_compile(), do you know use_enable() function ? example :

src_compile() {
  distutils_src_compile $(use_enable fb2)
}

- You can drop src_install() because exported by disutils.eclass, and move DOCS 
  in global scope.

- is older version of python in portage is 2.4.6, so you can put dev-lang/python in depend

- ebuild header is out-dated

- do you know EAPI="2" (see devmanual) in this case you just have to define src_prepare() and apply your patch from this function.

 --> The rest seems to be good :)
Comment 12 Ivan Anishchuk 2009-07-23 14:38:27 UTC
Created attachment 198907 [details]
ebuild for odin-0.1.3

* dropped use-flag 'fb2', because it doesn't work
+ EAPI2
+ dropped src_install

What concretely i have to make with depends? Tell me pls... :)
Comment 13 Romain Perier (RETIRED) gentoo-dev 2009-07-24 05:52:04 UTC
- catdoc et poppler are need to install the package (emerge phase only) or to use it ? then have a look to http://devmanual.gentoo.org/general-concepts/dependencies/index.html  ;)

- be warn about KEYWORDS, only tested arch need to be keyworded

- dev-lan/python can normally be dropped from dep because already added by distutils.eclass and will be install by pygtk.

- in src_prepare , you can use ${P} instead of "odin-0.1.3", and you need to quote (double quotes) at least ${FILESDIR}, but usually we quote the full argument of epatch (a kind of ebuild writing convention)
Comment 14 Ivan Anishchuk 2009-07-24 11:13:40 UTC
(In reply to comment #13)
> - catdoc et poppler are need to install the package (emerge phase only) or to
> use it ? then have a look to
> http://devmanual.gentoo.org/general-concepts/dependencies/index.html  ;)

catdoc & poppler (pdf2text converter) are need to use it (with pipe).
 
> - dev-lan/python can normally be dropped from dep because already added by
> distutils.eclass and will be install by pygtk.

okey
 
> - in src_prepare , you can use ${P} instead of "odin-0.1.3", and you need to
> quote (double quotes) at least ${FILESDIR}, but usually we quote the full
> argument of epatch (a kind of ebuild writing convention)

okey
Comment 15 Ivan Anishchuk 2009-07-24 11:17:28 UTC
Created attachment 198976 [details]
ebuild for odin-0.1.3

minor fixes
Comment 16 Ivan Anishchuk 2009-07-24 11:20:19 UTC
Created attachment 198977 [details, diff]
patch to fix problem with zip-archives

i forget about this patch... :( it is needed to work properly with zip files
Comment 17 Romain Perier (RETIRED) gentoo-dev 2009-07-24 11:39:02 UTC
RDEPEND="dev-libs/libxml2
	>=dev-python/pygtk-2.2
	>=gnome-base/libglade-2.0
        ms-doc? ( app-text/catdoc )
        pdf? ( virtual/poppler )"
DEPEND="${RDEPEND}"

All libraries needed at compile time and at runtime need to be put into RDEPEND and DEPEND. And as you said, catdoc and poppler are needed to use it, so theorically move them to RDEPEND. 

Gilles that's what you wanted ?
Comment 18 Ivan Anishchuk 2009-07-24 16:46:35 UTC
(In reply to comment #17)

catdoc & poppler is needed only in runtime.
Comment 19 Ivan Anishchuk 2009-10-20 19:30:57 UTC
Created attachment 207724 [details]
ebuild for odin-0.1.4

Version bump. Yes, i've released new version...
Comment 20 Christopher Díaz Riveros (RETIRED) gentoo-dev Security 2017-08-25 17:54:08 UTC

RESOLVED as OBSOLETE since there is no update and package is not in tree

Coordinated with leio