222715 – toolchain-funcs.eclass : tc-arch-kernel does not return the correct value for FreeBSD

Bug 222715 - toolchain-funcs.eclass : tc-arch-kernel does not return the correct value for FreeBSD

Summary: toolchain-funcs.eclass : tc-arch-kernel does not return the correct value for...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	High normal
Assignee:	Gentoo Toolchain Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2008-05-18 20:17 UTC by Alexis Ballier
Modified:	2008-06-01 09:42 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch (fbsdhostkernel.patch,745 bytes, patch) 2008-05-18 20:19 UTC, Alexis Ballier	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexis Ballier gentoo-dev

2008-05-18 20:17:36 UTC

Man... this took me a while to understand why I couldn't build a cross toolchain for freebsd anymore.
We use the tc-arch-kernel function in freebsd-lib to determine which target kernel arch we will use and it now returns x86 here which is not a valid kernel for FreeBSD. This causes incomplete headers to be installed and the build fails at the cross gcc stage 1...


I'll attach a patch.

Comment 1 Alexis Ballier gentoo-dev

2008-05-18 20:19:05 UTC

Created attachment 153609 [details, diff]
patch

Comment 2 SpanKY gentoo-dev

2008-06-01 02:37:37 UTC

looks good, feel free to apply

Comment 3 Alexis Ballier gentoo-dev

2008-06-01 08:57:52 UTC

(In reply to comment #2)
> looks good, feel free to apply
> 

applied, thanks for the review.


mind if I also add a test for that in tests/toolchain-funcs.sh ?

Comment 4 SpanKY gentoo-dev

2008-06-01 09:42:21 UTC

as long as the tests continue to pass, should be OK :)