Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 222637 - media-video/lsdvd: Error in calculation of chapter length
Summary: media-video/lsdvd: Error in calculation of chapter length
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Media-video project
URL: http://sourceforge.net/tracker/index....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-18 13:00 UTC by Martin Thierer
Modified: 2008-06-10 18:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch fixing the bug (lsdvd-0.16-usec.patch,973 bytes, patch)
2008-05-18 13:01 UTC, Martin Thierer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Thierer 2008-05-18 13:00:42 UTC
There is a bug in the calculation of microseconds of chapter duration (missing braces). This error adds up when using the single durations to calculate chapter start times.

I'll add a patch fixing the problem for me.

I've also reported the bugfix upstream, but given the lacking activity on the project page on sf.net I'd appreciate it if the patch would be added to the ebuild as well.


Reproducible: Always
Comment 1 Martin Thierer 2008-05-18 13:01:40 UTC
Created attachment 153535 [details, diff]
Patch fixing the bug
Comment 2 Steve Dibb (RETIRED) gentoo-dev 2008-06-10 13:55:40 UTC
Martin, just for curiosity's sake (I use lsdvd a lot) can you paste an output where its not working properly?  I've never noticed this one before.
Comment 3 Steve Dibb (RETIRED) gentoo-dev 2008-06-10 14:08:26 UTC
Patch added in CVS, thanks Martin
Comment 4 Martin Thierer 2008-06-10 18:09:12 UTC
Hi Steve,

you can't tell only by the output that it's not working.

I'll append the diff between the output of the non-patched and the patched version of lsdvd 0.16 for "The Guardian".

You probably never noted because 1. not all chapters are affected and 2. the error is rather small so you won't notice until you add up the numbers and the error accumulates.

I found a few reports where people hit this error. Like in the bug tracker for lsdvd on sf.net (I add the link to the entry as URL for this bug).

You can check for example by using media-video/transcode which reports the correct chapter lengths.

Bye

Martin

diff lsdvd_bug.out lsdvd_fixed.out
2,7c2,7
< Title: 01, Length: 02:13:26.100 Chapters: 13, Cells: 18, Audio streams: 06, Subpictures: 23
<       Chapter: 01, Length: 00:08:47.090, Start Cell: 01
<       Chapter: 02, Length: 00:12:37.010, Start Cell: 06
<       Chapter: 03, Length: 00:10:08.250, Start Cell: 07
<       Chapter: 04, Length: 00:10:23.250, Start Cell: 08
<       Chapter: 05, Length: 00:10:58.170, Start Cell: 09
---
> Title: 01, Length: 02:13:26.880 Chapters: 13, Cells: 18, Audio streams: 06, Subpictures: 23
>       Chapter: 01, Length: 00:08:49.040, Start Cell: 01
>       Chapter: 02, Length: 00:12:37.400, Start Cell: 06
>       Chapter: 03, Length: 00:10:08.640, Start Cell: 07
>       Chapter: 04, Length: 00:10:23.640, Start Cell: 08
>       Chapter: 05, Length: 00:10:58.560, Start Cell: 09
9c9
<       Chapter: 07, Length: 00:16:01.410, Start Cell: 11
---
>       Chapter: 07, Length: 00:16:01.800, Start Cell: 11
14c14
<       Chapter: 12, Length: 00:06:46.330, Start Cell: 17
---
>       Chapter: 12, Length: 00:06:46.720, Start Cell: 17