Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 222423 - media-gfx/pqiv crashes sometimes
Summary: media-gfx/pqiv crashes sometimes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Samuli Suominen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-16 19:12 UTC by Rafał Mużyło
Modified: 2008-05-24 11:06 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2008-05-16 19:12:56 UTC
It's a silly description, but it's hard to shorten.
Most often I use pqiv as `qiv -n .`.
For some dirs it result in a crash.

I learned that the segfault seems to go away if I change:
options = (char**)g_malloc((argc + 250) * sizeof(char*));
into:
options = g_new0(char*, argc + 250);

Any idea what causes the crash ?
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2008-05-17 19:42:52 UTC
Phillip, care to look at this?
Comment 2 Phillip Berndt 2008-05-19 15:29:42 UTC
Sorry, I guess I forgot to include a patch against this in 0.7.

Please test if
 http://www.pberndt.com/raw//Programme/Linux/pqiv/_download/pqiv-0.7.1.tbz
fixes the bug (unpack, ./configure, make and ./qiv <somedir>)
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2008-05-23 12:33:11 UTC
Rafał?
Comment 4 Rafał Mużyło 2008-05-23 12:54:55 UTC
Sorry, for ignoring.
While I do use it, it worked for me with my fix
and wasn't a priority in the first place.
But, yeah, it looks like this +1 in g_malloc works too.
Comment 5 Rafał Mużyło 2008-05-23 12:57:55 UTC
Or, was it NULL-terminating options array ?
Anyway, it's OK now.
Comment 6 Phillip Berndt 2008-05-23 13:16:43 UTC
> Or, was it NULL-terminating options array ?
Correkt ;)

Samuli, please create an ebuild for the package linked above.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2008-05-24 11:06:00 UTC
(In reply to comment #6)
> > Or, was it NULL-terminating options array ?
> Correkt ;)
> 
> Samuli, please create an ebuild for the package linked above.
> 

Done. Thanks, closing..