GTKsubtitler is a tool for editing and converting subtitles for DivX films. It allows you to move subtitles, change their format, convert them to ISO-8859-1/2, and merge two sets of subtitles. This package only depends on GTK, but as a result of a current bug Gnome is required as a dependency as well. Trying to disable gnome during configuration just results in a lot of internal errors. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 12798 [details] gtksubtitler-0.2.4.ebuild (New Package)
Created attachment 12799 [details] ChangeLog
Comment on attachment 12799 [details] ChangeLog ># ChangeLog for media-video/gtksubtitler ># Copyright 2002-2003 Gentoo Technologies, Inc.; Distributed under the GPL v2 ># $Header: $ > >*gtksubtitler-0.2.4 (3 June 2003) > > 3 June 2003; Adam Mondl <tocharian@barrysworld.com> gtksubtitler-0.2.4.ebuild: > Initial release.
a few points that need improving 1) never depend on the gnome-meta package, find the right deps in configure.in or similar . Can you maybe patch out it's gnome dep if it only needs gtk+, that would be much nicer. 2) SRC_URI would be easier with ${P} or ${PV} at least 3) You should set the package name to lowercase using a ${MY_P} var or something and use it troughout the ebuild. Setting ${S} correctly with that for example you don't need to use both cd statements . 4) again with the correct use ${MY_P} the src_unpack part can be removed.
Created attachment 13085 [details] Modified ebuild with proposed changes. I took care of the Gnome dependency as well as incorporated ${P} and ${PV}. I added a non-functional MY_P variable but I am still not sure how to take care of the v in the filename. Please explain further how I could solve this problem.
i know this is an application written in gtk and using the gnome libraries, but the application itself fits more in a video/media category ? thoughts ?
i suppose app-editor needs to be considered. Depends on wheter video/tv herd is willing to take it. The ebuilds itsself : the gtk dep is 1.2 only i suppose so should be '=x11-libs/gtk+-1.2*' i don't like the usage of gawk there, although it's baselayout it isn't really needed (in essence it adds another dep). easiest is to just define ${MY_P}=<text>-${PV} and use that troughout.
Created attachment 17054 [details] Modified Ebuild with newer changes I added an einfo giving the location of the binary since it is not all lowercase. Also I tried to fix the two things foser mentioned.
Created attachment 17187 [details] Modified Ebuild with newer changes DEPEND="=x11-libs/gtk+-1.2*" typo
I guess under GLEP policy #17 this bug should be closed as a won't fix.
Project has been closed.
