Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 22194 - XMMS patch to handle russian encodings (CP1251->KOI8-R)
Summary: XMMS patch to handle russian encodings (CP1251->KOI8-R)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: rob holland (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-04 05:22 UTC by Sergey Kuleshov (RETIRED)
Modified: 2003-08-19 05:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for recoding CP1251->KOI8-R (autorecode-xmms1.2.7-0.1.1.tar.gz,16.79 KB, patch)
2003-06-04 05:23 UTC, Sergey Kuleshov (RETIRED)
Details | Diff
Patch for recoding CP1251->KOI8-R (autorecode-xmms1.2.7-0.1.1.patch,56.55 KB, patch)
2003-06-05 06:17 UTC, Sergey Kuleshov (RETIRED)
Details | Diff
Another version of the patch. (xmms-ds-recode.patch,107.82 KB, patch)
2003-06-26 02:52 UTC, Sergey Kuleshov (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Kuleshov (RETIRED) gentoo-dev 2003-06-04 05:22:47 UTC
At the moment many russian users are suffering from the fact that most of mp3
tags are written using CP1251 (windows) encoding while for linux native russian
coding is KOI8-R. This patch allows xmms to automatically detect the tags, which
are in cp1251 and konvert them into koi8-r.

Reproducible: Always
Steps to Reproduce:
Comment 1 Sergey Kuleshov (RETIRED) gentoo-dev 2003-06-04 05:23:58 UTC
Created attachment 12775 [details, diff]
Patch for recoding CP1251->KOI8-R
Comment 2 Sergey Kuleshov (RETIRED) gentoo-dev 2003-06-05 06:17:12 UTC
Created attachment 12825 [details, diff]
Patch for recoding CP1251->KOI8-R

Sorry, the first one was tgz. My mistake.
Comment 3 rob holland (RETIRED) gentoo-dev 2003-06-06 11:10:08 UTC
Shouldn't this be included upstream rather than by us? Have you sent this to the xmms devs?
Comment 4 Sergey Kuleshov (RETIRED) gentoo-dev 2003-06-06 11:20:09 UTC
I will definetly send this patch xmms devlopers. However there are a number of problems with this: first of all none has any idea when next xmms will be released (if ether at all). Secondly the simmilar patch existed for earlier versions of XMMS (1.2.4 I guess) but it was NEVER included in xmms. So I believe this should be dealt by you, guys, at least till the upstream devs will do it.
Comment 5 Sergey Kuleshov (RETIRED) gentoo-dev 2003-06-26 02:52:10 UTC
Created attachment 13885 [details, diff]
Another version of the patch.

This is a newer version of patch. It also provides some GUI settings and allows
you choose the encondigs manually. Also it is not limmited to KOI8/CP1251, but
has CP866/UTF.

P.S. I guess upstream will notice it much sooner, than you actually add this
easy patch.
Comment 6 rob holland (RETIRED) gentoo-dev 2003-06-26 04:16:57 UTC
Commited, many thanks :)
Comment 7 Sergey Kuleshov (RETIRED) gentoo-dev 2003-08-19 05:16:45 UTC
Just for furute refference. This patch is taken from http://rusxmms.sourceforge.net/ .