Bug 221753 – [PATCH]media-video/ogmrip-0.11.2-r1 + 0.12.1 fail with -Werror option

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Jiří Moravec 2008-05-11 21:52:44 UTC]

Unhandled return values from write/fwrite functions throw error with -Werror compilation.

Reproducible: Always

Steps to Reproduce:
1. Compile ogmrip with -Werror option



Actual Results:  
cc1: warnings being treated as errors
ogmrip-vobsub.c: In function 'ogmrip_vobsub_run':
ogmrip-vobsub.c:131: warning: ignoring return value of 'write', declared with attribute warn_unused_result

cc1: warnings being treated as errors
theoraenc.c: In function ‘main’:
theoraenc.c:572: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
theoraenc.c:573: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
theoraenc.c:602: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
theoraenc.c:603: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result


Expected Results:  
media-video/ogmrip-0.11.2-r1 merged

I use hardened profile with gcc-4.2.3/glibc-2.7

[Comment 1 Jiří Moravec 2008-05-11 21:56:13 UTC]

Created attachment 152879 [details, diff]
Patch for bug 221753

[Comment 2 Olivier Rolland 2008-05-12 18:48:29 UTC]

Created attachment 152973 [details, diff]
A slightly modified patch

[Comment 3 Olivier Rolland 2008-05-12 18:49:29 UTC]

Created attachment 152975 [details]
gmrip-0.11.2-r2.ebuild

This ebuild applies the patch above.

[Comment 4 Olivier Rolland 2008-05-12 18:49:54 UTC]

The patch has also been commited upstream. Thanks a lot.

[Comment 5 Panagiotis Christopoulos (RETIRED) 2008-08-14 10:02:41 UTC]

*** Bug 234685 has been marked as a duplicate of this bug. ***

[Comment 6 Panagiotis Christopoulos (RETIRED) 2008-08-14 10:12:50 UTC]

Olivier, 

also take a look at bug 234685 ,as this seems to happen to the 0.12.1 version too. Attila, has already written a small patch.

[Comment 7 Olivier Rolland 2008-08-29 19:09:05 UTC]

Created attachment 164076 [details, diff]
ogmrip-0.11.2-subp2pgm.patch

This patch fixes a compilation error when using the hardened profile.

[Comment 8 Olivier Rolland 2008-08-29 19:09:44 UTC]

Created attachment 164078 [details]
ogmrip-0.11.2-r2.ebuild

This ebuild applies the patches above.

[Comment 9 Olivier Rolland 2008-08-29 19:21:17 UTC]

Created attachment 164083 [details, diff]
ogmrip-0.12.1-as-needed.patch

This patch fixes errors when linking with --as-needed.

[Comment 10 Olivier Rolland 2008-08-29 19:26:21 UTC]

Created attachment 164085 [details]
ogmrip-0.12.1-r1.ebuild

This ebuild applies the patch above and this patch http://bugs.gentoo.org/attachment.cgi?id=164079 which fixes compilation errors when using the hardened profile.

[Comment 11 Steve Dibb (RETIRED) 2008-12-03 14:31:59 UTC]

dropped the old ebuild from the tree