Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 221235 - sys-apps/net-tools-1.60_p20071202044231-r1 contains code outside the scope of an ebuild
Summary: sys-apps/net-tools-1.60_p20071202044231-r1 contains code outside the scope of...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-10 16:03 UTC by Santiago M. Mola (RETIRED)
Modified: 2008-05-11 00:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Santiago M. Mola (RETIRED) gentoo-dev 2008-05-10 16:03:15 UTC
Relevant part:
---------------------

maint_pkg_create() {
	cd /usr/local/src/net-tools
	#git-update
	local stamp=$(git log -n1 --pretty=format:%ai | sed -e 's:[- :]::g' -e 's:+.*::')
	local pv="${PV/_p*}_p${stamp}"
	local p="${PN}-${pv}"
	git-archive --prefix="${p}/" HEAD | lzma > "${T}"/${p}.tar.lzma
	du -b "${T}"/${p}.tar.lzma
}

pkg_setup() { [[ -n ${VAPIER_LOVES_YOU} ]] && maint_pkg_create ; }

---------------------

This kind of maintainance code belongs to external scripts or ebuilds in maintainers' overlay, and not in-tree ebuilds. While this is not stable (and I don't think it's stable candidate either) and doesn't imply a problem for the end-user, I don't think this is a good practice.
Comment 1 Mark Loeser (RETIRED) gentoo-dev 2008-05-10 19:53:37 UTC
Mike:  Can you please provide a reason for why you think this is invalid?  It seems to me like it shouldn't be in the ebuild at all.
Comment 2 SpanKY gentoo-dev 2008-05-10 21:12:21 UTC
the notion of a functions to assist in package management has already been discussed and accepted on gentoo-dev ... feel free to browse the archives
Comment 3 Bo Ørsted Andresen (RETIRED) gentoo-dev 2008-05-10 23:44:41 UTC
(In reply to comment #2)
> the notion of a functions to assist in package management has already been
> discussed and accepted on gentoo-dev ... feel free to browse the archives

That's bug 185567. Obviously the correct solution is to get that properly implemented rather than adding more hacks...
Comment 4 SpanKY gentoo-dev 2008-05-11 00:15:43 UTC
yet there's no valid reason at all to block developers from making their lives easier considering there is no downside