Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 221127 - x11-misc/xkeyboard-config-1.2 misses gettext build-time dependency
Summary: x11-misc/xkeyboard-config-1.2 misses gettext build-time dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-09 19:23 UTC by Mart Raudsepp
Modified: 2009-06-23 21:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2008-05-09 19:23:24 UTC
x11-misc/xkeyboard-config-1.2 unfortunately does not ship with .mo files prebuilt, so it requires msgfmt and other gettext tool on runtime, so a gettext dependency is missing. As libintl is provided by glibc or other means typically, and not by gettext, it probably shouldn't be a runtime dependency, that'd cost much.

It seems this is a new dependency since 1.2, as 1.1 doesn't do anything with the .po files - indeed, 1.2 adds translation support and requires a matching libxklavier and all that.
Comment 1 Mart Raudsepp gentoo-dev 2008-05-09 19:24:04 UTC
make[1]: Entering directory `/var/tmp/portage/x11-misc/xkeyboard-config-1.2/work/xkeyboard-config-1.2/po'
file=`echo af | sed 's,.*/,,'`.gmo \
	  && rm -f $file &&  -o $file af.po
/bin/sh: line 1: -o: command not found
make[1]: *** [af.gmo] Error 127
make[1]: Leaving directory `/var/tmp/portage/x11-misc/xkeyboard-config-1.2/work/xkeyboard-config-1.2/po'
make: *** [all-recursive] Error 1
 * 
 * ERROR: x11-misc/xkeyboard-config-1.2 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_compile
 *             environment, line 2055:  Called die
 * The specific snippet of code:
 *       emake || die "make failed"
 *  The die message:
 *   make failed
 * 
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/x11-misc/xkeyboard-config-1.2/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/x11-misc/xkeyboard-config-1.2/temp/environment'.
 * 
Comment 2 Mart Raudsepp gentoo-dev 2008-05-09 19:24:45 UTC
(uclibc chroot) martr-gentoo xkeyboard-config-1.2 # emerge --info
Portage 2.1.5_rc7 (uclibc/x86, gcc-4.3.0, uclibc-0.9.28.3-r6, 2.6.24-gentoo-r3 x86_64)
=================================================================
System uname: 2.6.24-gentoo-r3 x86_64 AMD Athlon(tm) 64 Processor 3500+
Timestamp of tree: Thu, 08 May 2008 07:15:01 +0000
app-shells/bash:     3.2_p39
dev-lang/python:     2.4.4-r6
sys-apps/baselayout: 2.0.0
sys-apps/openrc:     0.2.3
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.62
sys-devel/automake:  1.10.1-r1
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.25-r1
ACCEPT_KEYWORDS="x86 ~x86"
CBUILD="i386-gentoo-linux-uclibc"
CFLAGS="-Os -mtune=geode -pipe"
CHOST="i386-gentoo-linux-uclibc"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-Os -mtune=geode -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks nodoc noinfo noman parallel-fetch sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ftp.linux.ee/pub/gentoo/distfiles/ http://trumpetti.atm.tut.fi/gentoo/"
LDFLAGS="-Wl,-O1,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/root/overlay /root/x11"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="bindist cli cracklib dri midi mudflap ncurses nocxx openmp pcre perl readline reflection session spl ssl tcpd uclibc x86 xcb xorg zlib" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="uclibc" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LINGUAS, MAKEOPTS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 3 Donnie Berkholz (RETIRED) gentoo-dev 2008-05-09 22:22:29 UTC
Want to provide a patch for our ebuild, and preferably also supply an upstream patch so it's fixed in 1.3?
Comment 4 Mart Raudsepp gentoo-dev 2008-05-10 00:09:25 UTC
adding gettext to build time dependencies seems an obvious fix for downstream. Upstream code does call the m4 macro that sets gettext up, that macro just happens to not depend on pkg-config to enforce it.
.mo files being included in the tarball would just be a nice thing, not strictly required or anything - many many packages don't include them, this one just happens to be a package that gets used by a tiny X using embedded system and it's easier to build it if they are already included. For example most of GNOME does not include .mo files (they depend on intltool on build-time anyway for more functionality), but glib does include .mo files in the tarball as a low-level library.
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2008-05-18 02:36:19 UTC
01:52 < dberkholz > leio: could you just commit that gettext change yourself
02:09 <      leio > dberkholz: can you state that on the bug if you already 
                    haven't? My work mail should get notice and I'll do it 
                    first thing Monday morning at office then :)
Comment 6 Rémi Cardona (RETIRED) gentoo-dev 2009-02-27 18:40:10 UTC
Hrm, I'm not sure I get the problem right. Mart, care to shed some light on this?

Thanks
Comment 7 Mart Raudsepp gentoo-dev 2009-03-01 22:27:32 UTC
xkeyboard-config requires tools at build time that are provided by the gettext package. xkeyboard-config ebuild does not DEPEND on gettext for those tools, so the build fails on embedded or depcleaned environments. The package needs to build-time dep on gettext because it is required for creating the .mo files out of .po files with gmsgfmt and co. It should not be a runtime dependency however, because glibc in case of linux provides the runtime requirements, not gettext, so people might want to get rid of that big gettext package for rootfs image deployments.
Comment 8 Rémi Cardona (RETIRED) gentoo-dev 2009-06-23 21:30:50 UTC
Sigh... sorry for taking so long. Fixed in all available ebuilds and in the x11 overlay.

Thanks