Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 221077 - conditional interix3 patch for media-sound/esound-0.2.38-r1
Summary: conditional interix3 patch for media-sound/esound-0.2.38-r1
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: x86 Interix
: High normal
Assignee: Gentoo non-Linux Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-09 13:19 UTC by Fabian Groffen
Modified: 2009-10-25 09:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2008-05-09 13:19:46 UTC
esound-0.2.38-r1.ebuild contains a conditional to apply an interix patch.  The conditional is interix3.  The patch adds guards for interix, hence I assume it is conditional for interix != 3.5, because other interix versions do work or something.

This style of patching reminds me pretty much of the notorious Gentoo for Mac OS X age, and I have several (including personal) reasons to dislike this modus operandi.

Can't you do something like
#if __INTERIX > 3
or write a configure check to set a proper guard?

Upstream can't ever accept this patch, and we want to get rid of patches in Gentoo, and send them upstream instead, which means a conflict.

Please discuss.  This kind of patching also brings us a step further away of main tree integration, as it is in general not just my disagreement with this kind of patching, but that of the entire dev community.
Comment 1 Markus Duft (RETIRED) gentoo-dev 2008-05-13 06:36:24 UTC
the only option there would be writing a configure check. __INTERIX is a value-less define, and there is no other one describing the host system (correctly).

You're probably right, that the patch isn't that good. I first ported esound to interix 5.2 and 6.0 so 3.5 was somehow like a stepchild :) it was just hacked in there afterwards.
Comment 2 Fabian Groffen gentoo-dev 2009-10-25 09:45:56 UTC
this probably won't ever get fixed.