Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 220835 - media-plugins/gst-plugins-neon-0.10.6-r1 should run eautoreconf (patches configure.ac)
Summary: media-plugins/gst-plugins-neon-0.10.6-r1 should run eautoreconf (patches conf...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal with 1 vote (vote)
Assignee: GStreamer package maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-08 01:08 UTC by Ed Catmur
Modified: 2008-06-29 20:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gst-plugins-neon-0.10.6-r1.ebuild (gst-plugins-neon-0.10.6-r1.ebuild,426 bytes, text/plain)
2008-05-08 01:10 UTC, Ed Catmur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Catmur 2008-05-08 01:08:40 UTC
media-plugins/gst-plugins-neon-0.10.6-r1 has:

src_unpack() {
	gst-plugins-bad_src_unpack
	epatch "${FILESDIR}"/${P}-neon-0.28.1.patch
}

neon-0.28.1.patch has:

--- configure.ac	2008/03/23 23:09:39	1.1
+++ configure.ac	2008/03/23 23:10:15
@@ -747,7 +747,7 @@ AG_GST_CHECK_FEATURE(NAS, [nas plug-in],
 dnl *** neon ***
 translit(dnm, m, l) AM_CONDITIONAL(USE_NEON, true)
 AG_GST_CHECK_FEATURE(NEON, [neon http client plugins], neonhttpsrc, [
-  PKG_CHECK_MODULES(NEON, neon >= 0.26.0  neon <= 0.27.99, HAVE_NEON="yes", [
+  PKG_CHECK_MODULES(NEON, neon >= 0.26.0  neon <= 0.29.99, HAVE_NEON="yes", [
     HAVE_NEON="no"
     AC_MSG_RESULT(no)
   ])

However, media-plugins/gst-plugins-neon-0.10.6-r1 doesn't run eautoreconf, so patching configure.ac has no effect.

Result:

configure: *** checking feature: neon http client plugins ***
configure: *** for plug-ins: neonhttpsrc ***
checking for NEON... no
configure: *** These plugins will not be built: neonhttpsrc
...
configure: *** Plug-ins with dependencies that will NOT be built:
...
        neonhttpsrc
...

Eventual result is that neonhttpsrc is built but is not linked against -lneon.  Result of this is that neon gst-plugin fails to load.

Fix: run eautoreconf after epatch.
Comment 1 Ed Catmur 2008-05-08 01:10:34 UTC
Created attachment 152407 [details]
gst-plugins-neon-0.10.6-r1.ebuild

--- /usr/portage/media-plugins/gst-plugins-neon/gst-plugins-neon-0.10.6-r1.ebuild	2008-04-13 17:06:47.000000000 +0100
+++ gst-plugins-neon-0.10.6-r1.ebuild	2008-05-07 01:46:19.000000000 +0100
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/media-plugins/gst-plugins-neon/gst-plugins-neon-0.10.6-r1.ebuild,v 1.2 2008/04/13 15:42:37 hollow Exp $
 
-inherit gst-plugins-bad
+inherit gst-plugins-bad autotools
 
 KEYWORDS="~amd64 ~x86"
 
@@ -15,4 +15,5 @@ DEPEND="${RDEPEND}
 src_unpack() {
 	gst-plugins-bad_src_unpack
 	epatch "${FILESDIR}"/${P}-neon-0.28.1.patch
+	eautoreconf
 }
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2008-06-29 20:31:09 UTC
thanks, but I've version clean upped the directory instead. current is 0.10.7 iirc.