Bug 220225 – net-misc/icaclient-10.6-r3 locking assertion failures with x11-libs/libxcb-1.1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ed Catmur 2008-05-04 12:41:40 UTC]

Launching a Citrix session through the nsplugin gives xcb locking assertion failures:

Locking assertion failure.  Backtrace:
#0 /usr/lib/libxcb-xlib.so.0(xcb_xlib_unlock+0x40) [0xb7c0e910]
#1 /usr/lib/libX11.so.6 [0xb7e11011]
#2 /usr/lib/libX11.so.6(XCheckIfEvent+0xcb) [0xb7de10fb]
#3 /opt/ICAClient/wfica.bin(NCSXEventProcess+0x44) [0x8119374]
#4 /opt/ICAClient/wfica.bin [0x8093e46]
#5 /opt/ICAClient/wfica.bin(Thrd_givePrimaryControl+0x14) [0x8094030]
#6 /opt/ICAClient/wfica.bin(Vp_begin+0x10) [0x811e7f0]
#7 /opt/ICAClient/wfica.bin(OldMain+0x177) [0x8078c57]
#8 /opt/ICAClient/wfica.bin(PlatAppMain+0x28) [0x811e420]
#9 /opt/ICAClient/wfica.bin(AppMain+0x10b) [0x80f117b]
#10 /opt/ICAClient/wfica.bin(main+0x4a) [0x811e3ca]
#11 /lib/libc.so.6(__libc_start_main+0xe0) [0xb7c8e400]
#12 /opt/ICAClient/wfica.bin(XMapRaised+0x39) [0x8078a11]

Fix is to export LIBXCB_ALLOW_SLOPPY_LOCK=1 in a wrapper script (or wait for libxcb-1.2).

[Comment 1 Ed Catmur 2008-05-04 12:43:00 UTC]

Created attachment 151799 [details]
icaclient-10.6-r3.ebuild

ebuild with wrapper script.

--- /usr/portage/net-misc/icaclient/icaclient-10.6-r3.ebuild	2008-04-11 23:36:46.000000000 +0100
+++ icaclient-10.6-r3.ebuild	2008-05-04 13:40:01.000000000 +0100
@@ -1,6 +1,6 @@
 # Copyright 1999-2008 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/net-misc/icaclient/icaclient-10.6-r3.ebuild,v 1.6 2008/04/11 22:24:43 maekke Exp $
+# $Header: $
 
 inherit eutils multilib rpm
 
@@ -94,9 +94,13 @@ src_install() {
 	doins lib/ICAClient/util/{XCapture,XCapture.ad,echo_cmd,icalicense.sh,integrate.sh,nslaunch,pac.js,pacexec,xcapture}
 	dosym /opt/ICAClient/util/integrate.sh /opt/ICAClient/util/disintegrate.sh
 
+	# wfica has libxcb locking bugs, so provide a wrapper.  It needs to be in
+	# /opt/ICAClient to ensure it gets called, so rename wfica to wfica.bin.
 	exeinto /opt/ICAClient
-	doexe lib/ICAClient/wfcmgr lib/ICAClient/wfcmgr.bin lib/ICAClient/wfica \
+	doexe lib/ICAClient/wfcmgr lib/ICAClient/wfcmgr.bin \
 		lib/ICAClient/wfica_assoc.sh lib/ICAClient/wfica.sh
+	newexe lib/ICAClient/wfica wfica.bin
+	make_wrapper wfica 'env LC_ALL="" LANG="" LIBXCB_ALLOW_SLOPPY_LOCK=1 /opt/ICAClient/wfica' . /opt/ICAClient /opt/ICAClient
 
 	doenvd "${FILESDIR}"/10ICAClient

[Comment 2 Ed Catmur 2008-05-06 21:48:42 UTC]

Created attachment 152167 [details]
icaclient-10.6-r3.ebuild

Oops.

--- /usr/portage/net-misc/icaclient/icaclient-10.6-r3.ebuild	2008-04-11 23:36:46.000000000 +0100
+++ icaclient-10.6-r3.ebuild	2008-05-06 22:47:14.000000000 +0100
@@ -94,9 +94,13 @@ src_install() {
 	doins lib/ICAClient/util/{XCapture,XCapture.ad,echo_cmd,icalicense.sh,integrate.sh,nslaunch,pac.js,pacexec,xcapture}
 	dosym /opt/ICAClient/util/integrate.sh /opt/ICAClient/util/disintegrate.sh
 
+	# wfica has libxcb locking bugs, so provide a wrapper.  It needs to be in
+	# /opt/ICAClient to ensure it gets called, so rename wfica to wfica.bin.
 	exeinto /opt/ICAClient
-	doexe lib/ICAClient/wfcmgr lib/ICAClient/wfcmgr.bin lib/ICAClient/wfica \
+	doexe lib/ICAClient/wfcmgr lib/ICAClient/wfcmgr.bin \
 		lib/ICAClient/wfica_assoc.sh lib/ICAClient/wfica.sh
+	newexe lib/ICAClient/wfica wfica.bin
+	make_wrapper wfica 'env LC_ALL="" LANG="" LIBXCB_ALLOW_SLOPPY_LOCK=1 /opt/ICAClient/wfica.bin' . /opt/ICAClient /opt/ICAClient
 
 	doenvd "${FILESDIR}"/10ICAClient

[Comment 3 Christian Faulhammer (RETIRED) 2008-05-11 19:12:32 UTC]

We go with the fix.  Thanks for reporting and I would really like to see you become a Gentoo developer.