Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 219442 - gvfs installs bash-completion module in a wrong location
Summary: gvfs installs bash-completion module in a wrong location
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-27 10:26 UTC by Stefano Varesi
Modified: 2008-08-21 12:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to make bash-completion optional (gvfs-0.2.3-with-bash-comp-dir.patch,2.21 KB, patch)
2008-04-30 18:14 UTC, Arun Raghavan (RETIRED)
Details | Diff
Patch to gvfs-0.2.3.ebuild to make bash-completion optional (gvfs-0.2.3-ebuild-with-bash-completion.patch,1.27 KB, patch)
2008-04-30 18:20 UTC, Arun Raghavan (RETIRED)
Details | Diff
Patch to gvfs-0.2.3.ebuild to make bash-completion optional (gvfs-0.2.3-with-bash-comp-dir.patch,1.96 KB, patch)
2008-05-20 10:51 UTC, Arun Raghavan (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefano Varesi 2008-04-27 10:26:22 UTC
gvfs installs a module for bash-completion in /etc/profile.d/gvfs-bash-completion.sh but the correct location for bash-completion modules is /usr/share/bash-completion (a correct name for the module should be simply /usr/share/bash-completion/gvfs).
Currently, the gvfs module can not be handled (enabled/disabled) by 'eselect bashcomp' and is always enabled, because /etc/profile.d/* is sourced at login time.

Reproducible: Always

Steps to Reproduce:
Comment 1 Arun Raghavan (RETIRED) gentoo-dev 2008-04-30 18:14:36 UTC
Created attachment 151446 [details, diff]
Patch to make bash-completion optional

This patches gvfs to provide a couple of handy configure options w.r.t. bash-completion (enable/disable, directory to install to).
Comment 2 Arun Raghavan (RETIRED) gentoo-dev 2008-04-30 18:20:28 UTC
Created attachment 151447 [details, diff]
Patch to gvfs-0.2.3.ebuild to make bash-completion optional
Comment 3 Arun Raghavan (RETIRED) gentoo-dev 2008-04-30 18:21:23 UTC
(In reply to comment #1)
> Created an attachment (id=151446) [edit]
> Patch to make bash-completion optional
> 
> This patches gvfs to provide a couple of handy configure options w.r.t.
> bash-completion (enable/disable, directory to install to).

Submitted upstream at http://bugzilla.gnome.org/show_bug.cgi?id=530772
Comment 4 Arun Raghavan (RETIRED) gentoo-dev 2008-05-20 10:51:13 UTC
Created attachment 153733 [details, diff]
Patch to gvfs-0.2.3.ebuild to make bash-completion optional

This is the patch that made it to upstream svn.
Comment 5 Rémi Cardona (RETIRED) gentoo-dev 2008-08-21 12:12:25 UTC
I pushed a variation of Arun's patch to CVS yesterday as gvfs-0.2.5-r2.

Thanks for the patches!