Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 219318 - media-video/vlc: option --rc-fake-tty stopped working from version 0.8.6d
Summary: media-video/vlc: option --rc-fake-tty stopped working from version 0.8.6d
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Media-video project
URL: https://trac.videolan.org/vlc/ticket/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-26 07:46 UTC by Juha Aatrokoski
Modified: 2008-05-18 15:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for vlc-0.8.6f that reverts the introduced bug (vlc-0.8.6f-faketty.patch,870 bytes, patch)
2008-04-26 07:49 UTC, Juha Aatrokoski
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Juha Aatrokoski 2008-04-26 07:46:48 UTC
In VLC version 0.8.6d changes were added to modules/control/rc.c that prevent the use of the RC interface from another program. In effect these changes disable the RC interface if --rc-fake-tty is used. These changes appear to be absent from 0.9.0, so they are most likely a bug and not a bugfix.

Reproducible: Always

Steps to Reproduce:
1. run VLC 0.8.6[def] with vlc --intf rc --rc-fake-tty <file>
2. try to use the rc interface from the terminal (e.g. "help")

Actual Results:  
Nothing happens: input is ignored, no output produced.

Expected Results:  
The RC interface should work with --rc-fake-tty.
Comment 1 Juha Aatrokoski 2008-04-26 07:49:00 UTC
Created attachment 150989 [details, diff]
Patch for vlc-0.8.6f that reverts the introduced bug
Comment 2 Alexis Ballier gentoo-dev 2008-04-30 07:51:31 UTC
yep these changes were introduced in:

http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=c37341f13f0d0a7ef847a9caf1688d01882627ce


This seems to fix a bug of cpu consumption with the rc interface. Could you please try to open a ticket on trac.videolan.org (I couldnt find one for this) that would explain that this causes regressions ?
I'm not sure if the patch can be reverted like that without causing more problems.
Comment 3 Juha Aatrokoski 2008-04-30 11:03:49 UTC
> This seems to fix a bug of cpu consumption with the rc interface. Could you
> please try to open a ticket on trac.videolan.org (I couldnt find one for this)
> that would explain that this causes regressions ?

I cannot open a ticket there because I don't have an account and the account creation does not work. Perhaps someone with a working account could do this?
Comment 4 Alexis Ballier gentoo-dev 2008-04-30 11:05:55 UTC
(In reply to comment #3)
> > This seems to fix a bug of cpu consumption with the rc interface. Could you
> > please try to open a ticket on trac.videolan.org (I couldnt find one for this)
> > that would explain that this causes regressions ?
> 
> I cannot open a ticket there because I don't have an account and the account
> creation does not work. Perhaps someone with a working account could do this?


just ask for one in #videolan on freenode; it usually is very quick to get one ;)
(or perhaps they have some web irc somewhere)
Comment 5 Juha Aatrokoski 2008-05-12 10:57:33 UTC
This is now submitted to VLC: https://trac.videolan.org/vlc/ticket/1581
Comment 6 Alexis Ballier gentoo-dev 2008-05-12 11:25:45 UTC
thanks
Comment 7 Alexis Ballier gentoo-dev 2008-05-18 15:34:28 UTC
0.8.6g has just hit the tree and should fix this