Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 219110 - net-dns/dlint: Version bump to 1.4.1 and fixups (ebuild attached)
Summary: net-dns/dlint: Version bump to 1.4.1 and fixups (ebuild attached)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Andrej Kacian (RETIRED)
URL: http://www.domtools.com/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-24 06:20 UTC by Alexander Skwar
Modified: 2008-04-24 16:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
dlint-1.4.1.ebuild (dlint-1.4.1.ebuild,866 bytes, text/plain)
2008-04-24 06:21 UTC, Alexander Skwar
Details
patch dlint-1.4.0-r2.ebuild to dlint-1.4.1.ebuild (dlint-1.4.0-r2.ebuild_dlint-1.4.1.ebuild.patch,774 bytes, patch)
2008-04-24 06:21 UTC, Alexander Skwar
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Skwar 2008-04-24 06:20:31 UTC
In tree, there's dlint 1.4.0. Current version is 1.4.1.
Additionally, the URL specified in the HOMEPAGE field <http://www.domtools.com/dns/dlint.shtml> no longer exists.

Attached ebuild fixes this..

Further more, the command

  sed -i -e "s:+\$i:-n +\$i:g" dlint

generated bad commands in the dlint shell script. When run with "bash -x", it returned:

++ tail --lines=-n +4 /var/tmp/dlintns.11309
++ head -n 1
tail: n: ungültige Anzahl von Zeilen

Note the "--lines=-n +4". The correct command would've been "--lines=+4" (even just "-n".

Finally, the sed replacing /usr/local/bin/digparse with /usr/bin/digparse has been changed as well - no need to specify the complete path to digparse. It should be in the PATH anyway. And IMO it doesn't make sense to fully qualify the path to just one executable. Either all paths should be fully qualified or none.

In the attached ebuild, all this is fixed. I'll also attach a patch.
Comment 1 Alexander Skwar 2008-04-24 06:21:12 UTC
Created attachment 150799 [details]
dlint-1.4.1.ebuild
Comment 2 Alexander Skwar 2008-04-24 06:21:13 UTC
Created attachment 150800 [details, diff]
patch dlint-1.4.0-r2.ebuild to dlint-1.4.1.ebuild
Comment 3 Andrej Kacian (RETIRED) gentoo-dev 2008-04-24 16:45:17 UTC
Wow, I never expected another release. :) Committed!