Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 217131 - x11-misc/notification-daemon-0.4.0: patch for fixing upstream truncation bug
Summary: x11-misc/notification-daemon-0.4.0: patch for fixing upstream truncation bug
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Freedesktop bugs
URL: http://trac.galago-project.org/ticket...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-10 13:01 UTC by Pacho Ramos
Modified: 2009-03-23 18:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
notification-daemon-clipping.patch (notification-daemon-clipping.patch,939 bytes, patch)
2008-04-10 13:10 UTC, Pacho Ramos
Details | Diff
1.patch (1.patch,465 bytes, patch)
2009-01-25 19:20 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Pacho Ramos gentoo-dev 2008-04-10 13:10:46 UTC
Created attachment 149290 [details, diff]
notification-daemon-clipping.patch

This is the patch used by fedora that seems to work better:
https://bugzilla.redhat.com/show_bug.cgi?id=441099
Comment 2 Pacho Ramos gentoo-dev 2008-10-05 17:45:15 UTC
ping! Thanks
Comment 3 Pacho Ramos gentoo-dev 2008-11-20 21:09:08 UTC
Hi Cardoe!

I have seen that you have commited a bump with a patch for trying to fix this bug:
*notification-daemon-0.3.7-r1 (20 Nov 2008)

  20 Nov 2008; Doug Goldstein <cardoe@gentoo.org>
  +files/notification-daemon-0.3.7-line-wrapping.patch,
  +notification-daemon-0.3.7-r1.ebuild:
  upstream fix for handling line wrapping for lines longer then 50
  characters but shorter then 65

But seems that it fixes some of the cases but not all, on the other hand, attached patch on this bug (already used in fedora) fixes all cases I have tried.

For example, with the patch you have applied I still have this issue (at least with es_ES locale) when adding downloads to epiphany-2.22* download list

Maybe this is one of the cases John McCann was referring in:
https://bugzilla.redhat.com/show_bug.cgi?id=441099#c4

Anyway, maybe other option could be simply bump to notification-daemon-0.4:
http://galago-project.org/files/releases/source/notification-daemon/notification-daemon-0.4.0.NEWS

Thanks a lot
Comment 4 Doug Goldstein (RETIRED) gentoo-dev 2008-11-20 21:18:59 UTC
I had actually originally planned on going straight to 0.4.0, but it appeared there was a bunch of post-0.4.0 churn over graphics glitches as pointed out by some other devs so I held off on 0.4.0.

I wasn't even aware of this bug, I'll look at the Red Hat fix instead of comment #0's patch.
Comment 5 Pacho Ramos gentoo-dev 2008-11-21 11:19:49 UTC
The patch I am using is comment #1 one, it is from:
ftp://ftp.free.fr/pub/Distributions_Linux/Fedora/releases/9/Everything/source/SRPMS/notification-daemon-0.3.7-9.fc9.src.rpm

and seems to work ok (at least for me)
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-01-16 09:56:18 UTC
duplicate of bug #253332. Also in bug #252521.

*** This bug has been marked as a duplicate of bug 253332 ***
Comment 7 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-01-16 09:56:38 UTC
oops wrong bug, sorry.
Comment 8 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-01-16 09:57:04 UTC
is this fixed in 0.4 ?
Comment 9 Pacho Ramos gentoo-dev 2009-01-16 14:42:27 UTC
(In reply to comment #8)
> is this fixed in 0.4 ?
> 

Seems that yes :-)
Comment 10 Pacho Ramos gentoo-dev 2009-01-25 19:20:31 UTC
Created attachment 179693 [details, diff]
1.patch

Sadly, this is still valid :-(

Steps to reproduce:
1. Use es_ES locale
2. Launch "epiphany" and go to ftp://ftp.free.fr/pub/Distributions_Linux/Fedora/development/source/SRPMS
3. Click on xorg-x11-server-1.5.99.901-1.fc11.src.rpm

Results -> a notification will be shown showing that the file has been added to download list, this message appears truncated

The good side is that attached patch fixes this issue :-)
Comment 11 Pacho Ramos gentoo-dev 2009-01-25 19:20:51 UTC
Reopening then
Comment 12 Pacho Ramos gentoo-dev 2009-01-25 19:31:15 UTC
Comment on attachment 179693 [details, diff]
1.patch

Still valid even with the patch, I was using wrong URL :-S

Proper steps are go to:
ftp://ftp.free.fr/pub/Distributions_Linux/Fedora/updates/10/SRPMS

and download xorg-x11-server-1.5.3-6.fc10.src.rpm

the problem is that now I don't know how to fix this :'(
Comment 13 Peter Volkov (RETIRED) gentoo-dev 2009-03-23 09:54:55 UTC
Pacho, could you create screenshot and open new upstream bug report, since currently upstream considers this issue to be solved (http://trac.galago-project.org/ticket/162 is closed as fixed). Thank you.
Comment 14 Pacho Ramos gentoo-dev 2009-03-23 18:47:35 UTC
(In reply to comment #13)
> Pacho, could you create screenshot and open new upstream bug report, since
> currently upstream considers this issue to be solved
> (http://trac.galago-project.org/ticket/162 is closed as fixed). Thank you.
> 

I already sent a new one:
http://trac.galago-project.org/ticket/178

and added it it URL field

But seems that this bug has disappeared since gnome-2.24 update :-O

Closing then