Bug 216972 – app-portage/eix-0.12.3: update-eix fail if KEEP_VIRTUALS='true' in /etc/eixrc

• Status: RESOLVED FIXED
• Product: Portage Development

[Description tzopik 2008-04-09 01:08:25 UTC]

update-eix --print PORTDIR
return:
Adding virtual overlays from /var/cache/eix ..
/usr/portage/

the string "Adding virtual overlays from /var/cache/eix .." make fail in script /usr/bin/update-eix-functions.sh

Reproducible: Always

Steps to Reproduce:
1. set KEEP_VIRTUALS='true' in /etc/eixrc
2. runing [update-eix-layman add] or [eix-sync]


Actual Results:  
type: update-eix-layman add
update-eix-layman: Cannot read functions.sh

Expected Results:  
update eix db from the overlay

[Comment 1 tzopik 2008-04-09 02:44:17 UTC]

i think the bug was intruduced in rev605 of eix in file "trunk/src/update-eix.cc"

in this revision the add line 257 in funcion "add_virtuals(vector<Override> &override_list, vector<Pathname> &add, string cachefile, string eprefix_virtual)", cause the bug:
257: INFO("Adding virtual overlays from %s ..\n", cachefile.c_str());

i think the sulotion is call "eixrc.print_var(var_to_print);" before
"add_virtuals(override_list, add_list, eix_cachefile, eixrc["EPREFIX_VIRTUAL"]);"


sorry for this bad english!

[Comment 2 tzopik 2008-04-09 02:46:09 UTC]

(In reply to comment #1)
> i think the bug was intruduced in rev605 of eix in file
> "trunk/src/update-eix.cc"
> 
> in this revision the add line 257 in funcion "add_virtuals(vector<Override>
> &override_list, vector<Pathname> &add, string cachefile, string
> eprefix_virtual)", cause the bug:
> 257: INFO("Adding virtual overlays from %s ..\n", cachefile.c_str());

https://projects.gentooexperimental.org/eix/changeset/605#file19

> 
> i think the sulotion is call "eixrc.print_var(var_to_print);" before
> "add_virtuals(override_list, add_list, eix_cachefile,
> eixrc["EPREFIX_VIRTUAL"]);"
> 
> 
> sorry for this bad english!
> 

[Comment 3 Martin Väth 2008-04-09 16:42:52 UTC]

Thanks for reporting and investigating.
Indeed, it seems that the order of actions in update-eix.cc is rather broken;
hopefully, I just didn't forget a reason why it was this way...
Should be fixed in current svn trunk (>=eix-0.12.4).

BTW: Glad to hear that somebody really *uses* KEEP_VIRTUALS=true ...

[Comment 4 tzopik 2008-04-09 18:13:37 UTC]

(In reply to comment #3)
> Thanks for reporting and investigating.
> Indeed, it seems that the order of actions in update-eix.cc is rather broken;
> hopefully, I just didn't forget a reason why it was this way...
> Should be fixed in current svn trunk (>=eix-0.12.4).
> 

i emerge the last svn trunk and the eix is fine.
thanks for the quik fix

> BTW: Glad to hear that somebody really *uses* KEEP_VIRTUALS=true ...
> 

this is a good funtionality of eix for view packages in all overlay, whith out sync layman -S all


i think the bug is fixed.

[Comment 5 Martin Väth 2008-06-25 19:40:05 UTC]

Closing since eix-0.13.0 is now in the tree.