Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 216873 (transcode-ffmpeg) - transcode patch for new ffmpeg includes directories
Summary: transcode patch for new ffmpeg includes directories
Status: RESOLVED FIXED
Alias: transcode-ffmpeg
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-08 14:16 UTC by valentin
Modified: 2008-04-23 14:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated ebuild (transcode-1.0.6_rc1-r1.ebuild,4.11 KB, application/octet-stream)
2008-04-08 14:17 UTC, valentin
Details
patch (fix_ffmpeg_includes.patch,11.23 KB, patch)
2008-04-08 14:18 UTC, valentin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description valentin 2008-04-08 14:16:14 UTC
ffmpeg project has recently changed its include directories from the old ones to newer ones. thus the majority of the projects that use them need to update their packages. since i'm using the svn version and since i'm tired of transcode that continues to give error when compiling against the svn version i've made a personal patch and ebuild, until the maistream fixes this issue.
i hope the ones who have had this problem and haven't already fixed it might do it with this patch. 
the patch doesn't change anything, with the exception of ffmpeg/avcodec.h string to the libavcodec/avcodec.h one (fixing in this way the includes) and thus is not to be held responsible for eventual problems that might arise.
the patch was tested only on amd64 but it should work without any flaw also on any other arch that uses ffmpeg - libavcodec.
Comment 1 valentin 2008-04-08 14:17:10 UTC
Created attachment 149102 [details]
updated ebuild
Comment 2 valentin 2008-04-08 14:18:34 UTC
Created attachment 149103 [details, diff]
patch
Comment 3 Alexis Ballier gentoo-dev 2008-04-09 16:12:09 UTC
hmm this would probably be better to support both old & new headers layout in order to have an easy migration
Comment 4 valentin 2008-04-09 18:19:59 UTC
(In reply to comment #3)
> hmm this would probably be better to support both old & new headers layout in
> order to have an easy migration
> 

the ebuild should have had this:

if has_version '>=media-video/ffmpeg-9999' ; then
        epatch ${FILESDIR}/fix_ffmpeg_includes.patch || die "epatch failed"
fi

instead of just

epatch ${FILESDIR}/fix_ffmpeg_includes.patch || die "epatch failed"

but i didn't have the time to recompile the portage ffmpeg to see if it works, so i've just omitted it. 

to have this patch applied on the mainstream it needs a conditional #if in the pre configure phase. also, this patch is meant to apply only on gentoo after it had applied the gentoo patches. i don't know if they're applied also outside.
sincerely i don't have enough time to verify this.
Comment 5 Alexis Ballier gentoo-dev 2008-04-14 07:42:59 UTC
fixed in 1.0.6_rc2 with a different approach that allows old layout too
Comment 6 GROG! 2008-04-23 14:12:07 UTC
I'm now having the same problem trying to upgrade 1.0.6_rc1 ro 1.0.6_rc2 on my x86-32 box. Rebuilding ffmpeg hasn't helped.