Summary says it, this is obviously needed due to the existance of bug #1768
Oh, I also just improved the einfo statement to make mention of the necessity of having i2c kernel options turned to at least M for this to work.
I'll take this one
Okay, committed. I chose not to increment the ebuild to -r1 b/c the changes are so minor and won't change anything for people to reinstall. Thanks.
I've cleaned the -modules ebuild up some more. Please have a look. The main thing is that the Makefile hacking should happen in src_unpack(), and not in src_compile(). HTH, -- Arcady Genkin
Created attachment 791 [details] updated slightly (compile fix) When you moved the hacking to unpack, you forgot to change directories in compile as well, we could eliminate the whole higher portion of the source tree, for that matter I think we should, what do you think? But the attached fixes that, as well as eliminating the redundant call to depmod -a in the pkg_postinst
Thanks for catching this. I applied your changes. To answer your question, we could set S="${WORKDIR}/${P}/modules" and that would be preffered, if not for the em8300.h header file, which doesn't live in the modules/ directory. Or did you have something else in mind?
Created attachment 801 [details, diff] Patch, just a thought This patch both complexifies and simplifies the ebuild, personally I think it is better this way, we don't have to deal with doing everything in ${S}/modules let me know what you think
I am not sure whether I like this. I, for one, would prefer simply setting: S="${WORKDIR}/${P}/modules" This way the rest of the sources are still there in case anything else is needed in the future, but the default directory is the correct one in src_compile and src_install. Personally, I really buy into the principle of the least mangling. ;^) I'll leave the final call to you, as the maintainer. Consider my advice, and then let me know what you want to do.
Created attachment 809 [details, diff] revised patch, less mangling ;-) (here is a surprise) I took your advice and, this patch sets the ${S} as you mentioned, also increased the verbosity of comments in the ebuild.
Created attachment 811 [details, diff] libraries thought no functional change this is another thought I had (boring day at work) simply prevents the installation by the libraries package of a tar.gz of the modules package not important, just nicer this way.
I keep forgetting about the new patches. Reopenning the bug. I'll look at them in the next day or so.
Committed both patches. Thanks.
