Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 216292 - media-sound/sndpeek improvements
Summary: media-sound/sndpeek improvements
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Cédric Krier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-05 08:24 UTC by Olivier Huber
Modified: 2009-08-08 18:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
modified ebuild (sndpeek-1.3.ebuild,1.77 KB, text/plain)
2008-04-05 08:26 UTC, Olivier Huber
Details
sndpeek eselect module (sndpeek.eselect,3.47 KB, text/plain)
2008-04-05 08:28 UTC, Olivier Huber
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Huber 2008-04-05 08:24:57 UTC
sndpeek can use several audio engines, but need to be build against it. The ebuild already take care about this, but you can only build against one and if you set multiple backends, you can't choose against which it's build. 

So I try to modify the ebuild a little bit :

- Now it builds sndpeek with every backend specified by USE flags and renames them to sndpeek-$backend
- I also wrote an eselect module (wrote is really too strong : I just copy vi.eselect and mostly s/vi/sndpeek and remove everything concerning man pages) to select the backend by setting the /usr/bin/sndpeek symlink

I'd like to draw dev's attention to these code in the ebuild :

- I use an ugly code in compil_backend() : mv sndpeek sndpeek-${backend} and emake clean to "save" the  sndpeek binary and to clean the directory. I think it can be better to use newbin but AFAIK it can't be use outside src_install.

- In sndpeek.eselect, I have some lines which lengths are bigger than 78 (it seems to me that many gentoo related stuff has such a rule) but as I'm not a bash guru I don't know were I should cut (for instance : 56,77,134)

Review and comments are greatly appreciated.
Comment 1 Olivier Huber 2008-04-05 08:26:43 UTC
Created attachment 148713 [details]
modified ebuild
Comment 2 Olivier Huber 2008-04-05 08:28:44 UTC
Created attachment 148714 [details]
sndpeek eselect module
Comment 3 Cédric Krier gentoo-dev 2008-04-05 15:55:09 UTC
I don't see the advantage of having the same application with different engines.
I you set many engines, the ebuild choose one in order of preference (jack, alsa, oss) depending of low-latency.
Comment 4 Olivier Huber 2008-04-07 10:31:24 UTC
(In reply to comment #3)
> I don't see the advantage of having the same application with different
> engines.
> I you set many engines, the ebuild choose one in order of preference (jack,
> alsa, oss) depending of low-latency.
> 

I think it can be a good thing to have different engines. For instance, when I want to do some audio editing, I start a RT-kernel and a jack server. But most of the time I don't start jack and instead I use alsa, because it suits my everyday needs.

I also think that Gentoo is about choice :-)
Comment 5 Cédric Krier gentoo-dev 2009-08-08 18:15:04 UTC
Fix in CVS
Thanks.