Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 216291 - sys-apps/shadow-4.1.1 has broken audit support
Summary: sys-apps/shadow-4.1.1 has broken audit support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-05 08:18 UTC by Alexey Shvetsov
Modified: 2008-04-20 06:59 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,48.43 KB, text/plain)
2008-04-05 08:19 UTC, Alexey Shvetsov
Details
shadow-4.1.1.ebuild.patch (shadow-4.1.1.ebuild.patch,274 bytes, patch)
2008-04-05 16:49 UTC, Arfrever Frehtes Taifersar Arahesis (RETIRED)
Details | Diff
proper audit support (shadow-4.1.1-audit-newgrp.patch,478 bytes, text/plain)
2008-04-06 03:48 UTC, Jory A. Pratt
Details
More sane and correct patch (shadow-4.1.1-fix-audit.patch,403 bytes, patch)
2008-04-15 21:08 UTC, Alex Unigovsky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvetsov archtester gentoo-dev 2008-04-05 08:18:11 UTC
Portage 2.2_pre5 (default/linux/amd64/2008.0/desktop, gcc-4.2.3, glibc-2.7-r2, 2.6.24-gentoo-r4 x86_64)
=================================================================
System uname: 2.6.24-gentoo-r4 x86_64 Intel(R) Core(TM)2 Quad CPU Q6600 @ 2.40GHz
Timestamp of tree: Sat, 05 Apr 2008 07:30:10 +0000
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.5
dev-lang/python:     2.5.1-r5
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 2.0.0
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.24
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O3 -pipe -march=native -mtune=native -ftree-vectorize"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/kde/4.0/env /usr/kde/4.0/share/config /usr/kde/4.0/shutdown /usr/share/config /var/bind /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O3 -pipe -march=native -mtune=native -ftree-vectorize"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache distlocks metadata-transfer parallel-fetch preserve-libs sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://192.168.0.60 http://distfiles.gentoo.org http://www.ibiblio.org/pub/Linux/distributions/gentoo http://gentoo.osuosl.org"
LANG="ru_RU.UTF-8"
LC_ALL=""
LDFLAGS="-Wl,-O1 -Wl,--sort-common"
LINGUAS="ru en"
MAKEOPTS="-j9"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/sunrise /usr/portage/local/layman/science /usr/portage/local/layman/sajinet /usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="7zip R X Xaw3d a52 aac acl acpi addbookmarks additions administrator akode alias alsa amarok amd64 amr amrnb amrwb apache2 audiofile audit autoreplace bash-completion berkdb bios blas branding bzip2 cairo caps catalogs cdr chm cli color-console connectionstatus contactnotes context cracklib crypt css cups curl cviewer cvs cyrillic dbus djvu doc double-precision dri dvd dvdr dvdread emboss emovix enca encode esd exif extra fam fame fbcondecor ffmpeg fftw firefox fits flac fontconfig fortran fpx ftp fuse games gcc4 gdb gdbm gif gimp git glitz gmp gnutls gphoto2 gpm grace graphics graphviz gs gsl gstreamer gtk hal hdri history humanities iceweasel icon iconv ieee1394 imagemagick inotify iproute2 ipv6 isdnlog ithreads jadetex java jbig jingle jpeg jpeg2k kde lame lapack latex lcms lesstif libffi libnotify libwww lm_sensors logrotate lyx lzo mad maps midi mikmod mjpeg mmx mng motif mp3 mp3rtp mpeg mpi mplayer mudflap multilib music mysql ncurses neXt netcdf newspr nfs nls nova nptl nptlonly nsplugin nxclient odk ogg omega openal openexr opengl openmp oscar pam pch pcre pdf perl pertty php plasma plotutils plugins png pnm postscript povray ppds pppd profile pstricks publishers pulseaudio python q32 qhull qt-copy qt3 qt3support qt4 query-browser quicktime radio rar rdesktop readline reflection resolvconf rtc ruby samba sasl sbcl science sdl sensord session sftp slang slp smp solver soundex speex spell spl sqlite srt sse sse2 ssl ssse3 startup-notification subversion svg svnserve symlink sysfs taglib tcl tcpd teamarena teletext tetex tex4ht theora threads tiff tk translator truetype unicode urandom usb utempter valgrind vboxbfe vhosts vim vim-syntax vnc vorbis webdav webpresence wmf workbench x264 x86emu xattr xcb xcomposite xen xetex xft xine xml xorg xscreensaver xulrunner xv xvid zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias ident version" APACHE2_MPMS="worker" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="ru en" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Alexey Shvetsov archtester gentoo-dev 2008-04-05 08:19:05 UTC
Created attachment 148711 [details]
build.log

build log =)
Comment 2 Michal Jakubowski 2008-04-05 10:32:24 UTC
Same
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2008-04-05 16:49:26 UTC
Created attachment 148758 [details, diff]
shadow-4.1.1.ebuild.patch
Comment 4 Norberto Bensa 2008-04-05 17:45:47 UTC
That's a workaround, not a patch. I don't know if I want my boxes without audit support... Thanks anyway
Comment 5 Jory A. Pratt gentoo-dev 2008-04-06 03:16:49 UTC
this is by far more then an enhancement. A $(use_enable audit) should and could be added to the ebuild. This is more of a blocker then anything. Audit support is a must for most admins in the workplace today.
Comment 6 Jory A. Pratt gentoo-dev 2008-04-06 03:48:03 UTC
Created attachment 148814 [details]
proper audit support 

Patch is pretty self explainitory. Any questions just ask.
Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2008-04-06 17:43:02 UTC
(In reply to comment #6)
> Patch is pretty self explainitory. Any questions just ask.

You forgot about handling of 'audit' USE flag in the ebuild:
--- shadow-4.1.1.ebuild
+++ shadow-4.1.1.ebuild
@@ -11,7 +11,7 @@
 LICENSE="BSD GPL-2"
 SLOT="0"
 KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ~ppc64 ~sparc ~x86"
-IUSE="nls pam selinux skey cracklib"
+IUSE="audit cracklib nls pam selinux skey"

 # Does not work with OpenPAM (yet?)
 RDEPEND="cracklib? ( >=sys-libs/cracklib-2.7-r3 )
@@ -54,6 +54,7 @@
                --with-libcrypt \
                --enable-shared=no \
                --enable-static=yes \
+               $(use_with audit) \
                $(use_with cracklib libcrack) \
                $(use_with pam libpam) \
                $(use_with skey) \
Comment 8 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2008-04-06 17:45:20 UTC
(In reply to comment #7)
I meant:
--- shadow-4.1.1.ebuild
+++ shadow-4.1.1.ebuild
@@ -11,10 +11,11 @@
 LICENSE="BSD GPL-2"
 SLOT="0"
 KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ~ppc64 ~sparc ~x86"
-IUSE="nls pam selinux skey cracklib"
+IUSE="audit cracklib nls pam selinux skey"

 # Does not work with OpenPAM (yet?)
-RDEPEND="cracklib? ( >=sys-libs/cracklib-2.7-r3 )
+RDEPEND="audit? ( sys-process/audit )
+       cracklib? ( >=sys-libs/cracklib-2.7-r3 )
        pam? ( >=sys-libs/pam-0.99 )
        !sys-apps/pam-login
        !app-admin/nologin
@@ -54,6 +55,7 @@
                --with-libcrypt \
                --enable-shared=no \
                --enable-static=yes \
+               $(use_with audit) \
                $(use_with cracklib libcrack) \
                $(use_with pam libpam) \
                $(use_with skey) \
Comment 9 Jory A. Pratt gentoo-dev 2008-04-06 20:18:46 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > Patch is pretty self explainitory. Any questions just ask.
> 
> You forgot about handling of 'audit' USE flag in the ebuild:

I did not forget about it I done explained it in an earlier post. Ever dev that works on shadow knows how to implement it without me providing a patch for them to use.
Comment 10 Norberto Bensa 2008-04-11 11:21:33 UTC
It seems dev knows how to but doesn't want to... 

Almost a week and the only change is a new USE flag (audit) which disables audit. I repeat: that's not a fix. 

Thanks,
Norberto


Comment 11 SpanKY gentoo-dev 2008-04-11 16:41:16 UTC
is the bug still open ?  yes ?  then no one said it was fixed

if you cant handle the timelines for fixes to get implemented, become a dev and get it fixed yourself
Comment 12 Norberto Bensa 2008-04-11 22:49:32 UTC
You, as a dev, could have masked the package. BTW, #6 works for me (tm)
Comment 13 Kyle Elbert 2008-04-12 01:11:38 UTC
still broke, i thought if there was i useflag IT WORKED, or was something new.Fix this thing already!!!!
Comment 14 Kyle Elbert 2008-04-12 01:15:33 UTC
oh, and #6 works here too.
Comment 15 SpanKY gentoo-dev 2008-04-12 20:36:51 UTC
we dont mask packages for trivial bugs
Comment 16 Norberto Bensa 2008-04-12 20:42:07 UTC
If it is soooo trivial. Fix it.
Comment 17 SpanKY gentoo-dev 2008-04-12 20:48:52 UTC
if you want to piss and moan, go to the forums.  or write a blog.  dont spam your crap on bugzilla.
Comment 18 Alex Unigovsky 2008-04-15 21:08:11 UTC
Created attachment 149850 [details, diff]
More sane and correct patch

Compiles and runs (/w audit logging) on ~x86
Comment 19 SpanKY gentoo-dev 2008-04-20 06:59:33 UTC
added fix from upstream to cvs, cheers