Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 215910 - dev-util/git: 72git.el fboundp test fails to add git to the load path
Summary: dev-util/git: 72git.el fboundp test fails to add git to the load path
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-02 17:52 UTC by Dimitris Vyzovitis
Modified: 2008-06-09 10:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitris Vyzovitis 2008-04-02 17:52:04 UTC
In dev-util/git, site-lisp info for emacs is loaded from 72gentoo.el
The file contains an fboundp for the symbol vc-git-registered which is not
available at eval time with emacs 22.2.
As a result git is not in the load-path etc.


Reproducible: Always

Steps to Reproduce:
1. fire emacs 22.2
2. (require 'git) [without having the git path in your .emacs]



Expected Results:  
git-mode...

This is easy to fix by dropping the fboundp check in 72gentoo.el [it is not there in earlier revisions of the file]
Comment 1 Dimitris Vyzovitis 2008-04-02 17:58:12 UTC
(In reply to comment #0)
> In dev-util/git, site-lisp info for emacs is loaded from 72gentoo.el
> The file contains an fboundp for the symbol vc-git-registered which is not
> available at eval time with emacs 22.2.
> As a result git is not in the load-path etc.
> 

Clarification:
Actually, the fboundp is probably not the culprit. 
The problem I am seeing is not having ...site-lisp/git in my load-path.
It works fine in emacs 22.1, but breaks in 22.2
Comment 2 Fernando J. Pereda (RETIRED) gentoo-dev 2008-06-09 08:00:37 UTC
I can't help there... reassigning to opfer, he should know.

- ferdy
Comment 3 Christian Faulhammer (RETIRED) gentoo-dev 2008-06-09 08:54:41 UTC
Redirecting to the Emacs team which is the real oracle of power for such questions.  Will have a look later today.
Comment 4 Ulrich Müller gentoo-dev 2008-06-09 09:54:43 UTC
See bug 194690: Emacs 22.2 contains native git support, so the code installed by dev-util/git was disabled to avoid collisions.
Comment 5 Christian Faulhammer (RETIRED) gentoo-dev 2008-06-09 10:24:48 UTC
(In reply to comment #4)
> See bug 194690: Emacs 22.2 contains native git support, so the code installed
> by dev-util/git was disabled to avoid collisions.

 Right.  Ferdy, we discussed  it on 2007-10-04 in #gentoo-dev for bug 194690

(20:10:44) ferdy: Opfer: I really don't like the 'elog' part in pkg_postinst
(20:12:06) ferdy: once that emacs version has been long enough in the tree, we'll just punt USE=emacs from git and call it a day
(20:13:41) Opfer: ferdy: We will keep several versions of GNU Emacs in the tree, at least 18 and 21 will stay there and 21 is supported for app-emacs packages.
(20:14:18) Opfer: ferdy: There is no sane way of depending on it as we have virtual/emacs-<major-version>, but git support will enter with 22.2, so you cannot hard dep on virtual/emacs-22.2
(20:15:09) ferdy: Opfer: how about using has_version ?
(20:16:34) Opfer: kingtaco|work: We won't, but why do you like it that much?
(20:16:53) Opfer: ferdy: Yeah, that is an alternative, or you leave the message out as no user will see the difference.
(20:17:14) Opfer: ferdy: < 22.2 will have the support files loaded, >=22.2 have it automatically.
(20:17:55) ferdy: Opfer: but we can even avoid installing dead stuff, right ?
(20:18:26) Opfer: ferdy: Yes, but you can have several Emacs versions in parallel.

You really should remember. ;-)
Comment 6 Fernando J. Pereda (RETIRED) gentoo-dev 2008-06-09 10:32:28 UTC
I had completely forgotten about it. So nothing to be done really. Feel free to RESOLVE->INVALID this bug.

- ferdy