Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 215658 - TAGS:: and TAG: in makefiles of xulrunner
Summary: TAGS:: and TAG: in makefiles of xulrunner
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-31 23:24 UTC by Pascal Bourguignon
Modified: 2008-04-01 16:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
patch correcting the bug. (TAGS-colon.patch,1.13 KB, patch)
2008-03-31 23:26 UTC, Pascal Bourguignon 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Bourguignon 2008-03-31 23:24:59 UTC 
net-libs/xulrunner-1.8.1.* cannot be compiled because there are both TAGS:: and TAGS: in a few makefiles.

Reproducible: Always

Steps to Reproduce:
1. emerge xulrunner
2.
3.




diff --exclude CVS --exclude _darcs --exclude '*~' --exclude '*.fasl' --exclude '*.fas' --exclude '*.lib' --exclude '*.[oa]' -Naur mozilla.original/config/rules.mk mozilla/config/rules.mk
--- mozilla.original/config/rules.mk	2008-03-31 00:55:31.000000000 +0200
+++ mozilla/config/rules.mk	2008-03-31 13:41:49.000000000 +0200
@@ -1825,7 +1825,7 @@
 
 tags: TAGS
 
-TAGS: $(SUBMAKEFILES) $(CSRCS) $(CPPSRCS) $(wildcard *.h)
+TAGS:: $(SUBMAKEFILES) $(CSRCS) $(CPPSRCS) $(wildcard *.h)
 	-etags $(CSRCS) $(CPPSRCS) $(wildcard *.h)
 	+$(LOOP_OVER_DIRS)
 
diff --exclude CVS --exclude _darcs --exclude '*~' --exclude '*.fasl' --exclude '*.fas' --exclude '*.lib' --exclude '*.[oa]' -Naur mozilla.original/gfx/cairo/cairo/test/Makefile.in mozilla/gfx/cairo/cairo/test/Makefile.in
--- mozilla.original/gfx/cairo/cairo/test/Makefile.in	2005-03-23 20:53:40.000000000 +0100
+++ mozilla/gfx/cairo/cairo/test/Makefile.in	2008-03-31 13:42:30.000000000 +0200
@@ -513,7 +513,7 @@
 	mkid -fID $$unique
 tags: TAGS
 
-TAGS:  $(HEADERS) $(SOURCES)  $(TAGS_DEPENDENCIES) \
+TAGS::  $(HEADERS) $(SOURCES)  $(TAGS_DEPENDENCIES) \
 		$(TAGS_FILES) $(LISP)
 	tags=; \
 	here=`pwd`; \
Comment 1 Pascal Bourguignon 2008-03-31 23:26:21 UTC 
Created attachment 147936 [details, diff]
patch correcting the bug.
Comment 2 Raúl Porcel (RETIRED) gentoo-dev 2008-04-01 16:43:47 UTC 
File a bug upstream, please