Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 215378 - app-mobilephone/gnokii-0.6.24 bump request
Summary: app-mobilephone/gnokii-0.6.24 bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Mobile Phone Developers (INACTIVE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-29 22:14 UTC by Gilles Dartiguelongue (RETIRED)
Modified: 2008-06-01 22:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gnokii-0.6.24.ebuild.patch (gnokii-0.6.24.ebuild.patch,4.04 KB, patch)
2008-04-20 21:21 UTC, Gilles Dartiguelongue (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-03-29 22:14:48 UTC
Hi there, 

couldn't find an announce for it but gnome-phone-manager-0.51 requires it so I can't commit it to the tree until then.

See also http://freshmeat.net/projects/gnokii/?branch_id=3434&release_id=274094
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-04-12 13:49:07 UTC
Can I bump it myself ?
Comment 2 Alin Năstac (RETIRED) gentoo-dev 2008-04-12 19:06:35 UTC
Sure, be my guest.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-04-20 21:21:04 UTC
Created attachment 150463 [details, diff]
gnokii-0.6.24.ebuild.patch

damn, I didn't thought this was such a monster... It seems upstream rewrote a big chunck of their build system which makes bumping quite hard :)

Here is a first incomplete patch, will try to complete later.
Comment 4 Alin Năstac (RETIRED) gentoo-dev 2008-06-01 12:21:52 UTC
gnokii-0.6.26 is now in the tree. However, I didn't imported anything from your patch, so if you think something new needs to get into the ebuild, just let me know.
Comment 5 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-06-01 12:31:22 UTC
afaics, 2 things can still use review:

 * what is strip-linguas ? Afaik upstream is finally using >=intltool-0.35 which should make obsolete any previous hacks to select installed locales (see the change I had in DEPEND).
 * econf could use some updating some switches disappeared while some new switches  aren't included at all (notably smsd which last time I touched this thing seemed pretty important).
Comment 6 Alin Năstac (RETIRED) gentoo-dev 2008-06-01 21:52:15 UTC
(In reply to comment #5)
>  * what is strip-linguas ? Afaik upstream is finally using >=intltool-0.35
> which should make obsolete any previous hacks to select installed locales (see
> the change I had in DEPEND).

strip-linguas is defined in eutils.eclass and AFAIK it is not obsolete. I dunno what intltool is supposed to do, but I'm sure it doesn't add linguas_xx flags to IUSE. You might find automated ways to filter LINGUAS content, but at the end you still have to add by hand all possible languages to IUSE. 

>  * econf could use some updating some switches disappeared while some new
> switches  aren't included at all (notably smsd which last time I touched this
> thing seemed pretty important).

Fixed in -r1.
Comment 7 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-06-01 22:11:37 UTC
(In reply to comment #6)
> (In reply to comment #5)
> >  * what is strip-linguas ? Afaik upstream is finally using >=intltool-0.35
> > which should make obsolete any previous hacks to select installed locales (see
> > the change I had in DEPEND).
> 
> strip-linguas is defined in eutils.eclass and AFAIK it is not obsolete. I dunno
> what intltool is supposed to do, but I'm sure it doesn't add linguas_xx flags
> to IUSE. You might find automated ways to filter LINGUAS content, but at the
> end you still have to add by hand all possible languages to IUSE.

sorry for not being clear, since intltool 0.35 series, linguas support has been greatly improved and should work without further manipulations than setting linguas in make.conf.

It should install only the locales and documentations you want without having to do anything in the ebuild, if not then there is a bug in the package.

You can see in gnome ebuilds or eclasses that there is no strip-linguas. Hope this is clearer :)