Bug 214809 – media-video/vlc-0.8.6e-r1 fails to build

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Charles Stewart 2008-03-25 23:09:12 UTC]

vlc fails to build with the follow build error:

i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../.. -DSYS_LINUX -I../../include -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -D_GNU_SOURCE -DLOCALEDIR=\"/usr/share/locale\" -DDATA_PATH=\"/usr/share/vlc\" -DPLUGIN_PATH=\"/usr/lib/vlc\" -O2 -D__VLC__ -D__PLUGIN__ -DMODULE_NAME=mkv -DMODULE_NAME_IS_mkv -Wsign-compare -Wall -O2 -march=pentium-m -pipe -pipe -MT libmkv_plugin_la-mkv.lo -MD -MP -MF .deps/libmkv_plugin_la-mkv.Tpo -c mkv.cpp  -fPIC -DPIC -o .libs/libmkv_plugin_la-mkv.o
mkv.cpp: In member function 'virtual bool dvd_chapter_codec_c::Enter()':
mkv.cpp:5848: error: no matching function for call to 'min(size_t&, long long unsigned int)'
mkv.cpp: In member function 'virtual bool dvd_chapter_codec_c::Leave()':
mkv.cpp:5871: error: no matching function for call to 'min(size_t&, long long unsigned int)'
make[4]: *** [libmkv_plugin_la-mkv.lo] Error 1

Please see the nabble.com link for explanation of the fix.

Reproducible: Always

Steps to Reproduce:
1. emerge =media-video/vlc-0.8.6e-r1
2. watch it die

Actual Results:  
emerge fails to build due to upstream build error propagated into portage

Expected Results:  
emerge succeeds and I get to watch videos through vlc

[Comment 1 Charles Stewart 2008-03-25 23:10:29 UTC]

Created attachment 147315 [details]
build failure log

[Comment 2 Charles Stewart 2008-03-25 23:11:57 UTC]

Created attachment 147316 [details]
irrelevant `emerge --info` that is going to be asked for anyway

[Comment 3 Jakub Moc (RETIRED) 2008-03-25 23:12:41 UTC]

Definitely nothing critical here... http://bugs.gentoo.org/page.cgi?id=fields.html#bug_severity

[Comment 4 Charles Stewart 2008-03-25 23:15:58 UTC]

Created attachment 147317 [details]
unified diff patch of fix

[Comment 5 Charles Stewart 2008-03-25 23:21:18 UTC]

(In reply to comment #3)
> Definitely nothing critical here...
> http://bugs.gentoo.org/page.cgi?id=fields.html#bug_severity
> 

True to that, but at the moment I was going by the definition:
"Critical: The software crashes, hangs, or causes you to lose data"

I would agree, but this package was marked stable on x86.

[Comment 6 Charles Stewart 2008-03-25 23:27:25 UTC]

Created attachment 147321 [details]
fixed ebuild with patch

[Comment 7 Charles Stewart 2008-03-25 23:27:49 UTC]

Created attachment 147322 [details]
ebuild diff

[Comment 8 Charles Stewart 2008-03-25 23:29:02 UTC]

There's the heavy lifting, just needs someone with CVS commit privileges...

[Comment 9 Alexis Ballier 2008-03-26 08:22:24 UTC]

weird; and 0.8.6e was fine ?

could you please check if:
http://git.videolan.org/gitweb.cgi?p=vlc.git;a=commit;h=8c55b82642441491f14486744abf6a145cd7d7db

helps instead; that's the one from upstream that I'll backport if it helps

[Comment 10 Charles Stewart 2008-03-26 14:48:41 UTC]

I know that 0.8.6d was fine, but I don't think I ever successfully compiled a 0.8.6e release until I applied one of the two patches.

The git patch works.

[Comment 11 Alexis Ballier 2008-03-27 11:36:41 UTC]

thanks, I've added the git patch backport to our patchset; please sync in a few hours and it should be good.

[Comment 12 L{DiracDelta(t)} 2008-04-08 14:39:58 UTC]

I'm still seeing this exact same issue on the video lan git trunk.  Will this patch be merged into the git source trunk?