Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 214667 - app-emacs/yasnippet (new ebuild)
Summary: app-emacs/yasnippet (new ebuild)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Default Assignee for New Packages
URL: http://code.google.com/p/yasnippet/
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2008-03-25 10:33 UTC by MATSUYAMA Tomohiro
Modified: 2008-06-19 12:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
yasnippet-0.4.4.ebuild (yasnippet-0.4.4.ebuild,750 bytes, text/plain)
2008-03-25 10:34 UTC, MATSUYAMA Tomohiro
Details
50yasnippet-gentoo.el (50yasnippet-gentoo.el,119 bytes, text/plain)
2008-03-25 10:34 UTC, MATSUYAMA Tomohiro
Details
yasnippet-0.4.4.ebuild (yasnippet-0.4.4.ebuild,833 bytes, text/plain)
2008-03-26 17:16 UTC, MATSUYAMA Tomohiro
Details
50yasnippet-gentoo.el (50yasnippet-gentoo.el,108 bytes, text/plain)
2008-03-26 17:16 UTC, MATSUYAMA Tomohiro
Details
yasnippet-0.5.2.ebuild (yasnippet-0.5.2.ebuild,1.06 KB, text/plain)
2008-04-26 15:05 UTC, MATSUYAMA Tomohiro
Details
dropdown-list-20080316.ebuild (dropdown-list-20080316.ebuild,346 bytes, text/plain)
2008-04-26 15:05 UTC, MATSUYAMA Tomohiro
Details
dropdown-list/dropdown-list-20080316.el.bz2 (dropdown-list-20080316.el.bz2,3.09 KB, text/plain)
2008-04-26 15:06 UTC, MATSUYAMA Tomohiro
Details
dropdown-list-20080316.ebuild (dropdown-list-20080316.ebuild,357 bytes, text/plain)
2008-04-26 15:12 UTC, MATSUYAMA Tomohiro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description MATSUYAMA Tomohiro 2008-03-25 10:33:17 UTC
New ebuild for yasnippet.

http://code.google.com/p/yasnippet/

yasnippet is yet another implementation of tempo/snippet. It seems to be very simple and very extensible.



Reproducible: Always
Comment 1 MATSUYAMA Tomohiro 2008-03-25 10:34:08 UTC
Created attachment 147235 [details]
yasnippet-0.4.4.ebuild
Comment 2 MATSUYAMA Tomohiro 2008-03-25 10:34:42 UTC
Created attachment 147237 [details]
50yasnippet-gentoo.el
Comment 3 Ulrich Müller gentoo-dev 2008-03-25 11:57:34 UTC
Hi, thank you for contributing this. Please allow me some comments:
   1. Is there any way to autoload the package? We made a large effort to
      get rid of almost all "require" and "load" statements in our site
      initialisation, and are therefore reluctant to add new ones.
   2. The snippets are not elisp files and should therefore go to
      ${SITEETC}/${PN}/ (maybe omit the "snippets" directory level).
   3. src_compile() and the empty DEPEND/RDEPEND assignments are redundant.
   4. yasnippet.el says GPL-2, and so does your ebuild. But the homepage
      says "MIT License". Which one is right?

2.-4. should be easy to fix.
Not sure about 1. Maybe we can autoload functions yas/initialize and yas/load-directory, and let the ebuild output a message that the user should initialize it in his .emacs?
Comment 4 MATSUYAMA Tomohiro 2008-03-26 17:16:04 UTC
Created attachment 147395 [details]
yasnippet-0.4.4.ebuild

Thanks for comments.

I fixed like:

  1. Now site file just defines yas/initialize autoload function. An user can use yasnippet according to pkg_postinst messages if necessary.
  2. Done except for omitting snippets directory. I think we should keep it.
  3. Done.
  4. Sorry, I forgot to fix it.
Comment 5 MATSUYAMA Tomohiro 2008-03-26 17:16:43 UTC
Created attachment 147396 [details]
50yasnippet-gentoo.el
Comment 6 Ulrich Müller gentoo-dev 2008-03-26 17:25:36 UTC
Thanks. But I overlooked:
   5. Use ${P} in SRC_URI.

(No need to repost the ebuild. I will add it to the Emacs overlay later and fix this small problem myself.)
Comment 7 Ulrich Müller gentoo-dev 2008-03-27 10:44:53 UTC
Committed to Emacs overlay. I have also added a "doc" USE flag that installs the HTML documentation.

However, looking at the source I found that it contains a bundled copy of dropdown-list.el (see <http://www.emacswiki.org/cgi-bin/wiki/dropdown-list.el>) which is even included inline in the one elisp file. So we would have namespace collisions if we ever decided to add dropdown-list as a package.

So, before yasnippet can go into Portage, you should ask upstream to either unbundle dropdown-list (which I would prefer), or to rename the respective functions of the inlined code.

Therefore, resolving as CANTFIX for the time being. Please reopen when the above issue is fixed.
Comment 8 MATSUYAMA Tomohiro 2008-04-26 15:05:31 UTC
Created attachment 151017 [details]
yasnippet-0.5.2.ebuild
Comment 9 MATSUYAMA Tomohiro 2008-04-26 15:05:57 UTC
Created attachment 151018 [details]
dropdown-list-20080316.ebuild
Comment 10 MATSUYAMA Tomohiro 2008-04-26 15:06:10 UTC
Created attachment 151019 [details]
dropdown-list/dropdown-list-20080316.el.bz2
Comment 11 MATSUYAMA Tomohiro 2008-04-26 15:11:26 UTC
Yasnippet developers still have a intention to include dropdown-list.el.

http://code.google.com/p/yasnippet/issues/detail?id=18&can=1

So, I

* created a ebuild for dropdown-list.el
* made yasnippet-0.5.2 depend on the dropdown-list.el ebuild
* add a workaround to avoid namespace collision by cut dropdown-list.el part from yasnippet.el

I don't know what is the best way. Please review.
Comment 12 MATSUYAMA Tomohiro 2008-04-26 15:12:59 UTC
Created attachment 151022 [details]
dropdown-list-20080316.ebuild
Comment 13 Ulrich Müller gentoo-dev 2008-04-26 16:04:01 UTC
This looks good, thank you.

Committed to Emacs overlay, with minor modifications. I've also added a site-init file for dropdown-menu.
Comment 14 Ulrich Müller gentoo-dev 2008-04-26 16:06:25 UTC
> I've also added a site-init file for dropdown-menu.

For dropdown-list, of course.
Comment 15 Ulrich Müller gentoo-dev 2008-06-19 12:19:23 UTC
app-emacs/dropdown-list-20080316 and app-emacs/yasnippet-0.5.5 committed to Portage tree.

Thank you for the contribution.