Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 214650 - sys-apps/openrc-9999 typo in timezone upgrade
Summary: sys-apps/openrc-9999 typo in timezone upgrade
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-25 08:48 UTC by Jakub Moc (RETIRED)
Modified: 2008-03-26 09:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Moc (RETIRED) gentoo-dev 2008-03-25 08:48:23 UTC
<snip>
# upgrade timezone file
if [[ ! -e ${ROOT}/etc/timezone ]] ; then
        (
        source "${ROOT}"/etc/conf.d/timezone
        [[ -n ${TIMEZONE} ]] && echo "${TIMEZONE}" > "${ROOT}"/etc/timezone
        )
fi
</snip>

Well, /etc/conf.d/timezone never existed, the configuration has always been in /etc/conf.d/clock AFAICR. Plus the new /etc/timezone location is still incompatible w/ sys-libs/timezone-data pkg_{postinst,config}, so I don't understand where's this supposed to be configured now really.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2008-03-25 15:42:49 UTC
Well thanks, but what's the /etc/timezone thing good for? As noted, nothing looks there, sys-libs/timezone-data still wants /etc/conf.d/clock.
Comment 3 Doug Goldstein (RETIRED) gentoo-dev 2008-03-25 16:26:58 UTC
I was hoping Mike could actually provide some more info on this file because I'd include it in my OpenRC ebuild. The OpenRC-9999 ebuild should move the creation of this file above the has_version check as well
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2008-03-25 20:12:48 UTC
Reopen; creating another file in /etc which isn't used anywhere doesn't make sense.
Comment 5 SpanKY gentoo-dev 2008-03-25 20:17:08 UTC
it is used elsewhere ... if it wasnt used at all, we wouldnt have created the variable in the first place
Comment 6 Doug Goldstein (RETIRED) gentoo-dev 2008-03-25 20:18:17 UTC
jakub, it's possible this file will be used in the future in ebuilds like timezone-data. Before we jump to conclusions, I've already contacted Mike to try and get more info from him on his intentions. E-mail was Message-ID: <47E94737.5030405@gentoo.org>
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2008-03-25 20:19:58 UTC
(In reply to comment #5)
> it is used elsewhere ... if it wasnt used at all, we wouldnt have created the
> variable in the first place

Sigh... I'm a bit old for these riddle games. Could you enlighten us *where* it's being used? timezone-data ebuild mangles the timezone to Factory since the configuration no longer exists in /etc/conf.d/clock for openrc users. Where are people supposed to configure the timezone? 
Comment 8 SpanKY gentoo-dev 2008-03-25 20:24:04 UTC
if you cant be bothered to keep up, then dont bother people who do keep up
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2008-03-25 20:33:13 UTC
(In reply to comment #8)
> if you cant be bothered to keep up, then dont bother people who do keep up

Yeah, great... Care to tell me where's this being used, if I can't keep up? I don't see anything newer anywhere in the tree.

http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-libs/timezone-data/timezone-data-2008b.ebuild?rev=1.1&view=markup
Comment 10 SpanKY gentoo-dev 2008-03-25 20:43:24 UTC
why exactly do you feel you need an explanation in order for this to be fixed?  you have never been involved with this sort of development.  if you need someone to hold your hand, go ask on irc or the forums.
Comment 11 Jakub Moc (RETIRED) gentoo-dev 2008-03-25 20:53:42 UTC
(In reply to comment #10)
> why exactly do you feel you need an explanation in order for this to be fixed? 
> you have never been involved with this sort of development.  if you need
> someone to hold your hand, go ask on irc or the forums.

Sigh. We obviously need to document it for our *users*, and we need the configuration file installed by default for *everyone* - with appropriate comments. Neither of which happens ATM, even after your last commit to timezone-data ebuild.

How about fixing this bug properly finally?
Comment 12 Doug Goldstein (RETIRED) gentoo-dev 2008-03-25 21:07:49 UTC
Rather then slinging insults, it might have been worth while to actually check and see if the code was being used. Instead, insults we slung for 6 hours and then silently the issue was fixed...

You might also want to stick an elog statement for the /etc/timezone code block since the /etc/conf.d/clock section has one to remove user confusion.
Comment 13 SpanKY gentoo-dev 2008-03-26 04:18:47 UTC
writing up documentation is a separate issue which Doug is tackling.  that does not require justification of things to you.  not that it really matters to users as the upgrade path is taken care of them, so they shouldnt really care.

this bug is fixed properly: there was a typo in the openrc ebuild, now there isnt.
Comment 14 Jakub Moc (RETIRED) gentoo-dev 2008-03-26 09:35:09 UTC
(In reply to comment #13)

- that file won't be created for anyone who hasn't 'migrated' (IOW, fresh installs) as it is now...
- if timezone-data is the only thing that uses such configuration file, then timezone-data ebuild should take care of creating it, not openrc which doesn't use it anywhere
- while talking about documentation aspects, all the comments about setting timezone that used to exist in /etc/conf.d/clock are now lost