21435 – Portage should leave the DISTCC_HOSTS variable alone

Bug 21435 - Portage should leave the DISTCC_HOSTS variable alone

Summary: Portage should leave the DISTCC_HOSTS variable alone

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Unclassified (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Nicholas Jones (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2003-05-21 13:38 UTC by Wayne Davison
Modified:	2011-10-30 22:22 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Wayne Davison 2003-05-21 13:38:35 UTC

Newer distcc versions allow the user to specify hostnames either via the
environment, or via files.  Thus, having portage force the DISTCC_HOSTS variable
actually interferes with this.  The fix is to remove this line from ebuild.sh:

[ -z "${DISTCC_HOSTS}" ] && DISTCC_HOSTS="localhost"

Note that this change will not cause any adverse effects, even with an older
distcc and a lack of a DISTCC_HOSTS var -- in such a case distcc will behave the
same as before (compiling on the local host), it will just warn a lot about the
missing info (which should help people to remember to fix their setup).

Comment 1 Zach Welch (RETIRED) gentoo-dev

2003-05-21 16:56:36 UTC

Nick, Care for me to fix this one?  I'm happy with removing that line.  
Wayne, Thanks for tracking this down; glad to see someone else is testing.

Cheers, Zach

Comment 2 Wayne Davison 2003-05-21 17:39:26 UTC

One more thing -- we might as well get rid of this line too:

export DISTCC_HOSTS

(Also in ebuild.sh.)

Comment 3 Nicholas Jones (RETIRED) gentoo-dev

2003-05-29 03:50:41 UTC

Done.
48-r1

Comment 4 Nicholas Jones (RETIRED) gentoo-dev

2003-05-29 03:50:51 UTC

Done.
48-r1