Bug 214239 – net-misc/rsync-3.0.0-r2 fails to build if USE=xattr (net-misc/rsync-3.0.0 builds fine)

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Martin Hauser 2008-03-22 12:47:28 UTC]

trying to emerge net-misc/rsync-3.0.0-r2 fails to build with an error in xattrs.c: 

xattrs.c: In function ‘send_xattr’:
xattrs.c:360: warning: comparison between pointer and integer
xattrs.c:374: warning: comparison between signed and unsigned
xattrs.c:360: error: label ‘name_len’ used but not defined

net-misc/rsync-3.0.0 builds fine.

For further information, see the attached build-log

[Comment 1 Martin Hauser 2008-03-22 12:48:08 UTC]

Created attachment 146876 [details]
build log for the crash

[Comment 2 Fabian Groffen 2008-03-22 14:08:27 UTC]

put this in the right category

[Comment 3 Fabian Groffen 2008-03-22 14:11:35 UTC]

I think this is a leopard problem, as I don't have it on Tiger.

[Comment 4 Martin Hauser 2008-03-22 16:30:34 UTC]

Oops, sorry. Missed that not by purpose. Changed now.

[Comment 5 Martin Hauser 2008-03-22 16:38:11 UTC]

Created attachment 146914 [details, diff]
Patch for xattrs.c

I've dug myself into xattrs.c and found the quite simple build error which came from the fact that one if statment would begin with if( && unless HAVE_LINUX_XATTRS was defined.

[Comment 6 Martin Hauser 2008-03-22 16:40:35 UTC]

Created attachment 146915 [details, diff]
new upload of patch (sorry messed the previous one up)

sorry for messing up previous patch.

[Comment 7 Fabian Groffen 2008-03-22 20:54:58 UTC]

this is a prefix thing, believe me.

[Comment 8 Fabian Groffen 2008-03-22 21:26:00 UTC]

this is not a leopard related issue, sorry.

You patch doesn't apply for some weird reason.
The code looks identical.  I'll remake the patch :/

[Comment 9 Martin Hauser 2008-03-22 21:30:53 UTC]

Uff, it doesn't apply? Interesting, it really should... let me know if you happen to find out the difference between your patch and mine....

the change is easy, just move the first && into the #ifdef HAVE_LINUX_XATTRS definition.

[Comment 10 Fabian Groffen 2008-03-22 21:35:53 UTC]

yeah, I did that.  I looked at it quite long... patch just sometimes is picky.  I just remade the patch, and applied it.  Compiling for me now with USE=xattr.

Thanks!