Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 213568 - repoman generates manifest with .o files but doesnt complain about them not being in cvs
Summary: repoman generates manifest with .o files but doesnt complain about them not b...
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-16 12:13 UTC by Robert Spillner
Modified: 2022-07-12 03:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Spillner 2008-03-16 12:13:58 UTC
Please remove entry for non-existing object-file from Manifest.

Reproducible: Always

Steps to Reproduce:
1. emerge gcc-config

Actual Results:  

>>> Verifying ebuild Manifests...

!!! A file listed in the Manifest could not be found: /usr/portage/sys-devel/gcc-config/files/wrapper-1.5.0.o


Easy workaround: manually remove entry from Manifest
Comment 1 Christian Heim (RETIRED) gentoo-dev 2008-03-16 12:42:29 UTC
Just recreated the Manifest, should be gone once the mirrors resync.
Comment 2 SpanKY gentoo-dev 2008-03-20 20:13:57 UTC
repoman shouldnt have allowed this in the first place
Comment 3 Zac Medico gentoo-dev 2008-03-28 05:25:03 UTC
I suppose we can add a "file.notadded" category for things like this.
Comment 4 SpanKY gentoo-dev 2008-03-30 19:53:58 UTC
i cant think of a reason why repoman should allow a commit when any files exist locally that are not committed
Comment 5 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2014-01-10 20:40:23 UTC
(In reply to SpanKY from comment #4)
> i cant think of a reason why repoman should allow a commit when any files
> exist locally that are not committed

Commit before was done without Portage afaik, not sure if relevant:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-devel/gcc-config/Manifest?revision=1.286&view=markup

Commit itself was done with Portage 2.2_pre2, perhaps it was a buggy release: 

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-devel/gcc-config/Manifest?revision=1.287&view=markup

Trying to reproduce with file present: 

!!! The following files are in your local tree but are not added to the master
!!! tree. Please remove them from the local tree or add them to the master tree.

Not reproducible, I can't commit it that way as it is blocked.

Trying to reproduce with file not present:

>>> Creating Manifest for /home/tomwij/gentoo-x86/dev-util/test

Not reproducible, the Manifest no longer contains the file.

The only way I have on mind to actually reproduce this is to remove the object file during the commit right after manifesting; as then repoman would perceive things to be okay, but proceed with committing the new tampered state. I don't think this is something we can account for.

Overall, unless this has happened a lot more times than this one occurrence, I think it's not worth the effort looking into this as it loses more than we gain.
Comment 6 Brian Dolbec (RETIRED) gentoo-dev 2017-03-16 00:46:55 UTC
Zac, what do you think...  seems file.notadded is still not part of repoman
Comment 7 Zac Medico gentoo-dev 2017-03-16 05:42:49 UTC
Yeah a file.notadded error sounds good. As it is, commit bails out abruptly like this:

	if myunadded:
		print(red(
			"!!! The following files are in your local tree"
			" but are not added to the master"))
		print(red(
			"!!! tree. Please remove them from the local tree"
			" or add them to the master tree."))
		for x in myunadded:
			print("   ", x)
		print()
		print()
		sys.exit(1)
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:21 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.