Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 213524 - media-gfx/splashutils-1.5.3.4: MNG Animation stops on clockskew - Bugfix attached
Summary: media-gfx/splashutils-1.5.3.4: MNG Animation stops on clockskew - Bugfix atta...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-15 18:37 UTC by Clemens Rabe
Modified: 2008-04-20 09:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to detect clockskews (splashutils-1.5.3.4-clockskew.patch,8.19 KB, patch)
2008-03-15 18:39 UTC, Clemens Rabe
Details | Diff
Slightly modified ebuild to apply the patch. (splashutils-1.5.3.4.ebuild,6.47 KB, text/plain)
2008-03-15 18:40 UTC, Clemens Rabe
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Clemens Rabe 2008-03-15 18:37:17 UTC
When using a looped mng animation in a splash-theme, e.g. a rotating logo, the animation stops sometimes when the clock is set in the clock init-script. This is because the animation timing uses the system clocks.
The applied patch resolves this issue by adding a thread used to detect clock skews and resetting the animations. In addition, the timing of the animation was changed, resulting in smoother animations when a lot of service refreshs or progress updates occur.

Reproducible: Always

Steps to Reproduce:
1. Use a theme with a looped mng animation.
2. When displaying the theme, change the current time. The animation will stop.
Comment 1 Clemens Rabe 2008-03-15 18:39:01 UTC
Created attachment 146244 [details, diff]
Patch to detect clockskews

This patch introduces an additional thread for clock skew detection and changes the timing for animations slightly.
Comment 2 Clemens Rabe 2008-03-15 18:40:11 UTC
Created attachment 146246 [details]
Slightly modified ebuild to apply the patch.

Ebuild that applies the patch.
Comment 3 Michal Januszewski (RETIRED) gentoo-dev 2008-04-20 09:07:25 UTC
Thanks for the nicely written bug description and the patch :)  I've found a simpler solution to the problem (switching from CLOCK_REALTIME to CLOCK_MONOTONIC), see http://repo.or.cz/w/fbsplash.git?a=commitdiff;h=e5baeebf73bc3fc86df9ee781793037a78a9461e

The fix is included in 1.5.4.1.