See: http://www.netfilter.org/projects/conntrack-tools/downloads.html
Jeroen when you bump ebuild, please, *read* INSTALL files and configure.in and update dependencies in ebuild. Also, please, comment what do you think about new kernel config options. Currently we have kernels from 2.6.16 up to 2.6.24. What kernel config options are required for which version. Thank you.
Created attachment 146548 [details] conntrack-tools-0.9.6.ebuild Also drop installation of .svn files. And check, you broke docs installation. Actually I've fixed deps, docs in my overlay (ebuild, work in progress attached), but as you stepped forward and bumped, now I need you to read trough INSTALL file and do all durty work that should be done. There are new kernel config options but they are mentioned only for latest kernel (2.6.24) while we have 2.6.18-2.6.24 versions in our tree. There are analogical options but with different names... So please, go and check in what options are required in older kernels.
Jaroen, also avoid patches for simple things like dropping -Werror. Use sed instead. One liner like sed -i '/-Werror \\/d' {.,src,extensions}/Makefile.in (not tested) should do the work much better and it's easier to maintain.
This version doesn't compile with gcc-3.4.6: In file included from sync-alarm.c:21: ../include/network.h:64: warning: declaration of 'conf' shadows a global declaration ../include/conntrackd.h:144: warning: shadowed declaration is here In file included from sync-mode.c:27: ../include/network.h:64: warning: declaration of 'conf' shadows a global declaration ../include/conntrackd.h:144: warning: shadowed declaration is here make[1]: *** [sync-mode.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: *** [sync-alarm.o] Error 1 mv -f .deps/cache.Tpo .deps/cache.Po make[1]: Leaving directory `/var/tmp/portage/net-firewall/conntrack-tools-0.9.6/work/conntrack-tools-0.9.6/src' make: *** [all-recursive] Error 1 This is already report to upstream. That why I didn't yet bump the package. Please before bump, ask me ?
I mask the ebuild until it will be fixed.
Cédric, are you sure that ebuild is the tree does not work? sed script I've posted in comment #3 (does the same as patch Jeroen did) works and fixes compilation problem. Also it's better to mask packages in profile/package.mask. What you did is clear indication for our arch teams that this package does not work on all archs... But it's not the issue here. And again, kernel configuration options ebuild checks should be checked *before* bump.
Ok, fixed and unmask. I think I was working on an old dir when testing the patch.
I already masked this version before I even put it in the tree, I think.
(In reply to comment #8) > I already masked this version before I even put it in the tree, I think. I sure did: # Jeroen Roovers <jer@gentoo.org> (19 Mar 2008) # Development version: =net-firewall/conntrack-tools-0.9.6 Also, upstream says this is a development release (and doesn't recommend upgrading to it). It's bound to break on certain configurations and platforms.
(In reply to comment #9) > > Also, upstream says this is a development release (and doesn't recommend > upgrading to it). It's bound to break on certain configurations and platforms. > See: http://people.netfilter.org/pablo/conntrack-tools/news.html "Upgrade is strongly recommended!" So I will unmask it.
(In reply to comment #9) > Also, upstream says this is a development release (and doesn't recommend > upgrading to it). It's bound to break on certain configurations and platforms. Sorry Jeroen, but have to CC you again. Taking into account that conntrack-tools are development it seems to me that masking of conntrack was too fast and it's better to unmask it. Missed homepage does not mean broken software or maybe it's even better to point homepage on conntrack-tools homepage? Cédric, ebuild could be improved further: 1. there were changes in ebuild which change installed files - revision bump is necessary. 2. INSTALL file has different requirement on linux kernel then ebuild has. It should be linux kernel version >= 2.6.18. 3. take a look at this page: http://people.netfilter.org/pablo/conntrack-tools/downloads.html It contains different requirements on minimal net-libs/libnfnetlink version. What's correct version? I think forcing upper version is safer that's why I had it in my ebuild. Reopening bug to take care of the above items. Thank you.
Fix in cvs, thanks
Thank you, Cédric. I'm happy now. But I still want to hear how Jeroen feels about unmasking conntrack too? See #11. Not reopening bug, since this bug is fixed, but I'm lazy to open new one for this discussing issue.
I happen to be on the netmon alias, so no need to additionally CC me. net-firewall/conntrack was merged into conntrack-tools quite a while ago, and both HOMEPAGE and SRC_URI are now defunct. I added to package.masks yesterday: one for conntrack and one for the conntrack-tools version bump that I felt wasn't perhaps up to standards yet. I guess that caused a lot of the confusion...
